On Wed, Mar 15, 2017 at 6:50 AM, Thanuja Jayasinghe <[email protected]> wrote:
> Hi Nuwandi, > > On Tue, Mar 14, 2017 at 1:54 PM, Nuwandi Wickramasinghe <[email protected] > > wrote: > >> >> >> On Tue, Mar 14, 2017 at 12:42 PM, Thanuja Jayasinghe <[email protected]> >> wrote: >> >>> Hi Gayan, >>> >>> Yes. We need to specially handle username claim("http://wso2.org/claims/ >>> username"). >>> >> So, it will always be http://wso2.org/claims/username, not configurable? >> > > I see following performance related concerns if we marked some claim as > the username claim using a property, > > > > - In every operation which we are going to specially handle for > username claim, we need to check that property > - If we want to get the username claim value, first we need to go > through claims to identify the username claim and then retrieve the value > for that claim > > Also, it will be much easier for the User object to retrieve username > claim from a claim URI rather than a property. (We don't have the API > support for retrieving claim value from a property) > > In a case like "email as username", we can still map the username claim to > the email attribute. Then we can map the same email attribute to email > claim to avoid the confusion. > If our implementation allows to map same attribute with 2 or more claims in a consistence manner ( consistent in all CURD operations) then I'm +1 to follow this approach Thanks ! > > >>> Shall we add a method to User[1] class to retrieve username? >>> >> +1 to have a method in User.java >> >>> >>> [1] - https://github.com/wso2/carbon-identity-mgt/blob/master/com >>> ponents/org.wso2.carbon.identity.mgt/src/main/java/org/wso2/ >>> carbon/identity/mgt/User.java >>> >>> Thanks, >>> Thanuja >>> >>> On Tue, Mar 14, 2017 at 12:12 PM, Gayan Gunawardana <[email protected]> >>> wrote: >>> >>>> Hi All, >>>> >>>> Don't we have to provide an API to get username claim from domain >>>> level. >>>> I am suggesting to have some thing like >>>> >>>> org.wso2.carbon.identity.mgt.User userStoreUser = identityStore. >>>> getUser(userId); >>>> userStoreUser.getUsernameClaim(); >>>> >>>> Currently we handle username claim as just an another claim but it >>>> should be treated as special claim because username is the human friendly >>>> unique identifier for users. >>>> >>>> In domain-config.yaml we can define username claim for each domain. >>>> >>>> Also another requirement is when we get username from out side >>>> application, we need to retrieve corresponding user from identity store so >>>> we need to set value got from out side to appropriate claim. In that case >>>> there should be a way to identify username claim. >>>> >>>> WDYT? >>>> >>>> Thanks, >>>> Gayan >>>> >>>> >>>> -- >>>> Gayan Gunawardana >>>> Software Engineer; WSO2 Inc.; http://wso2.com/ >>>> Email: [email protected] >>>> Mobile: +94 (71) 8020933 >>>> >>> >>> >>> >>> -- >>> *Thanuja Lakmal* >>> Senior Software Engineer >>> WSO2 Inc. http://wso2.com/ >>> *lean.enterprise.middleware* >>> Mobile: +94715979891 +94758009992 >>> >> >> >> >> -- >> >> Best Regards, >> >> Nuwandi Wickramasinghe >> >> Software Engineer >> >> WSO2 Inc. >> >> Web : http://wso2.com >> >> Mobile : 0719214873 >> > > Thanks, > Thanuja > > -- > *Thanuja Lakmal* > Senior Software Engineer > WSO2 Inc. http://wso2.com/ > *lean.enterprise.middleware* > Mobile: +94715979891 +94758009992 > -- Sagara Gunathunga Associate Director / Architect; WSO2, Inc.; http://wso2.com V.P Apache Web Services; http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
