Hi Godwin, On Tue, Nov 7, 2017 at 7:51 PM, Godwin Shrimal <god...@wso2.com> wrote:
> Hi Johan, > > > On Tue, Nov 7, 2017 at 7:33 PM, Johann Nallathamby <joh...@wso2.com> > wrote: > >> Hi Godwin, >> >> On Tue, Nov 7, 2017 at 7:11 PM, Godwin Shrimal <god...@wso2.com> wrote: >> >>> Hi Johann, >>> >>> Yes, these are not connectors but don't we need to follow the same >>> naming convention for these repos as well? >>> >> >> There are many other repos under wso2-extensions that don't follow this >> convention. My understanding is this convention is only suitable for >> authenticators and provisioning connectors. Not for the rest. E.g. >> identity-metadata-saml2, identity-data-publisher-authentication, >> identity-governance, and many more. Similarly for userstore connectors we >> have "identity-userstore-" convention. This is what I understood. If others >> think different please holler. >> > > In your examples identity-*metadata*-saml2, identity-*data-publisher* > -authentication, "identity-*userstore*-" (except identity-governance) > also follows the pattern. > Yes, we can follow some other naming convention if needed. I thought you were saying to follow same naming convention as provisioning connectors. > >> Let me try to put it in another way :). Once we have the 3 repos, the >> identity-client-scim2 repo will depend on the identity-scim2-common repo. >> Both these repos together can be used outside the IS product as well, >> purely as a client side library for scim2. Having the word "provisioning" >> in the middle would mean (according to my understanding of our convention) >> this is purely a connector for IS and has no business outside the scope of >> IS, which is not true. >> > > I am not totally aggree with this, then *"identity*-" prefix also give > the same feeling that's purely for IS conenctors weather we use > provisioning word or not. So I don't see any difference for using outside > the IS product with/without using "provisioning" word. > The word "identity" is to indicate that these are from identity domain. E.g. we have 5 repos starting as "identity-agent-", which are all agents that work outside IS, but in identity domain. "identity" doesn't mean it is in IS product. Regards, Johann. > >> Regards, >> Johann. >> >> >>> Thanks >>> Godwin >>> >>> >>> On Tue, Nov 7, 2017 at 6:40 PM, Johann Nallathamby <joh...@wso2.com> >>> wrote: >>> >>>> Hi Godwin, >>>> >>>> On Tue, Nov 7, 2017 at 6:02 PM, Godwin Shrimal <god...@wso2.com> wrote: >>>> >>>>> Hi Johan, >>>>> >>>>> >>>>> On Tue, Nov 7, 2017 at 11:23 AM, Johann Nallathamby <joh...@wso2.com> >>>>> wrote: >>>>> >>>>>> Hi Maheshika, >>>>>> >>>>>> Can we have following 3 repos for this project under wso2-extensions >>>>>> organization? >>>>>> >>>>>> 1. *identity-outbound-provisioning-scim2* >>>>>> >>>>>> For the outbound connector >>>>>> >>>>>> 2. *identity-scim2-common* >>>>>> >>>>>> don't we need to keep the grouping name in the repo as >>>>> *identity-provisioning-scim2-common* >>>>> >>>> >>>> My understanding is the parts "auth" and "provisioning" in the repo >>>> names, refer to the kind of connectors. This particular repo is not a >>>> connector repo per se, but a dependency to the connector. I think this name >>>> is fine. >>>> >>>> >>>>> >>>>> >>>>> >>>>> >>>>>> For common utilities for inbound and outbound connectors. E.g. >>>>>> AttributeMapper class in inbound connector which is needed for outbound >>>>>> connector as well. >>>>>> >>>>>> 3. *identity-client-scim2* >>>>>> >>>>>> Isn't this should be *identity-provisioning-scim2-* >>>>> *client * >>>>> >>>> >>>> Again same explanation as above. >>>> >>>> Regards, >>>> Johann. >>>> >>>> >>>>> >>>>> >>>>>> For SCIM2 client generated using SCIM2 swagger files. This will be >>>>>> used by outbound connector as well as can be used by anyone as standalone >>>>>> client. Ideally this should be used for the scim2 compliance test suite >>>>>> as >>>>>> well, but have failed to do so. >>>>>> >>>>>> Regards, >>>>>> Johann. >>>>>> >>>>>> On Mon, Oct 16, 2017 at 2:21 PM, Johann Nallathamby <joh...@wso2.com> >>>>>> wrote: >>>>>> >>>>>>> Yes, I also think we need to take the approach of using the Swagger >>>>>>> files and generate SDK because that is what standard Rest API world >>>>>>> will be >>>>>>> doing. We can find any issues early. >>>>>>> >>>>>>> Regards, >>>>>>> Johann. >>>>>>> >>>>>>> On Mon, Oct 16, 2017 at 2:18 PM, Gayan Gunawardana <ga...@wso2.com> >>>>>>> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Oct 16, 2017 at 1:21 PM, Isuranga Perera < >>>>>>>> isurangamper...@gmail.com> wrote: >>>>>>>> >>>>>>>>> Hi Gayan, >>>>>>>>> >>>>>>>>> In that case, I'll try to create an SDK from swagger and use it as >>>>>>>>> the client. >>>>>>>>> >>>>>>>> That would be great. >>>>>>>> >>>>>>>>> >>>>>>>>> Best Regards >>>>>>>>> >>>>>>>>> On Mon, Oct 16, 2017 at 9:12 AM, Gayan Gunawardana <ga...@wso2.com >>>>>>>>> > wrote: >>>>>>>>> >>>>>>>>>> Since you are looking for abstraction layer, can implement >>>>>>>>>> something like [1] for SCIM2 as well. >>>>>>>>>> >>>>>>>>>> [1] https://github.com/wso2-extensions/identity-inbound-provisio >>>>>>>>>> ning-scim/blob/master/components/org.wso2.carbon.identity.sc >>>>>>>>>> im.common/src/main/java/org/wso2/carbon/identity/scim/common >>>>>>>>>> /impl/ProvisioningClient.java >>>>>>>>>> >>>>>>>>>> On Sun, Oct 15, 2017 at 11:16 PM, Gayan Gunawardana < >>>>>>>>>> ga...@wso2.com> wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Sun, Oct 15, 2017 at 8:39 PM, Johann Nallathamby < >>>>>>>>>>> joh...@wso2.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> *[+ IsharaK, Omindu, Farasath]* >>>>>>>>>>>> >>>>>>>>>>>> On Sun, Oct 15, 2017 at 7:34 PM, Isuranga Perera < >>>>>>>>>>>> isurangamper...@gmail.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> I went through the scim2-compliance-test-suite [1] source >>>>>>>>>>>>> code, but I couldn't find an abstraction layer which separates >>>>>>>>>>>>> the SCIM 2 >>>>>>>>>>>>> client from the test and report modules. Is there any way I can >>>>>>>>>>>>> separate SCIM 2.0 client from [1] so that I can use it as the >>>>>>>>>>>>> SCIM 2.0 >>>>>>>>>>>>> client for the $subject. >>>>>>>>>>>>> >>>>>>>>>>>> There is no clear abstraction layer. Both SCIM2 compliance test >>>>>>>>>>> developed by Vindula and SCIM 1.1 outbound provisioning connector >>>>>>>>>>> are >>>>>>>>>>> utilized apache commons http client . >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> In addition to that, I found this[2] repository which contains >>>>>>>>>>>>> another SCIM client. can I know the completion level of this >>>>>>>>>>>>> project? >>>>>>>>>>>>> >>>>>>>>>>>> This is feign http client and Vindula found it hard to use. >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> In summary, there are 3 options which I can use to generate a >>>>>>>>>>>>> SCIM 2.0 client. >>>>>>>>>>>>> >>>>>>>>>>>> Most feasible way is to go with apache commons HttpClient but >>>>>>>>>>> better to give a try with swagger doc as well. >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> 1. Separate SCIM 2.0 client from [1] >>>>>>>>>>>>> 2. Separate SCIM 2.0 client from [2] >>>>>>>>>>>>> 3. Use swagger doc [3] to generate client >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> [1] https://github.com/wso2-incubator/scim2-compliance-test- >>>>>>>>>>>>> suite >>>>>>>>>>>>> [2] https://github.com/HansageeSJ/scim-client >>>>>>>>>>>>> [3] https://wso2.org/jira/browse/IDENTITY-5695 >>>>>>>>>>>>> >>>>>>>>>>>>> Appreciate any suggestions. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Best Regards >>>>>>>>>>>>> Isuranga Perera >>>>>>>>>>>>> >>>>>>>>>>>>> On Fri, Oct 13, 2017 at 9:42 AM, Gayan Gunawardana < >>>>>>>>>>>>> ga...@wso2.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Thu, Oct 12, 2017 at 5:33 PM, Johann Nallathamby < >>>>>>>>>>>>>> joh...@wso2.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Thu, Oct 12, 2017 at 1:28 PM, Isuranga Perera < >>>>>>>>>>>>>>> isurangamper...@gmail.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi IAM Team, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Currently, there is no $subject. Therefore I'm looking at >>>>>>>>>>>>>>>> implementing a SCIM2 Outbound Connector. I'm looking at >>>>>>>>>>>>>>>> identity-outbound-provisioning-scim [1] >>>>>>>>>>>>>>>> and scim2-compliance-test-suite [2]. Appreciate further >>>>>>>>>>>>>>>> suggestions. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Isuranga, >>>>>>>>>>>>>> >>>>>>>>>>>>>> It should be same as [1] you just have to think SCIM provider >>>>>>>>>>>>>> is version 2 and send http requests according to SCIM2 format. >>>>>>>>>>>>>> As a >>>>>>>>>>>>>> starting point you can setup existing SCIM provisioning >>>>>>>>>>>>>> connector and debug >>>>>>>>>>>>>> from point [1] so you will understand the flow. >>>>>>>>>>>>>> >>>>>>>>>>>>>> [1] https://github.com/wso2-extens >>>>>>>>>>>>>> ions/identity-outbound-provisioning-scim/blob/master/compone >>>>>>>>>>>>>> nts/org.wso2.carbon.identity.provisioning.connector.scim/src >>>>>>>>>>>>>> /main/java/org/wso2/carbon/identity/provisioning/connector/s >>>>>>>>>>>>>> cim/SCIMProvisioningConnector.java#L99 >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> [1] https://github.com/wso2-ex >>>>>>>>>>>>>>>> tensions/identity-outbound-provisioning-scim >>>>>>>>>>>>>>>> [2] https://github.com/wso2-in >>>>>>>>>>>>>>>> cubator/scim2-compliance-test-suite >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Best Regards >>>>>>>>>>>>>>>> Isuranga Perera >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>>>>> Architecture mailing list >>>>>>>>>>>>>>>> Architecture@wso2.org >>>>>>>>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Thanks & Regards, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> *Johann Dilantha Nallathamby* >>>>>>>>>>>>>>> Senior Lead Solutions Engineer >>>>>>>>>>>>>>> WSO2, Inc. >>>>>>>>>>>>>>> lean.enterprise.middleware >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Mobile - *+94777776950* >>>>>>>>>>>>>>> Blog - *http://nallaa.wordpress.com >>>>>>>>>>>>>>> <http://nallaa.wordpress.com>* >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Gayan Gunawardana >>>>>>>>>>>>>> Senior Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>>>>>>>>>> Email: ga...@wso2.com >>>>>>>>>>>>>> Mobile: +94 (71) 8020933 >>>>>>>>>>>>>> >>>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>>> Architecture mailing list >>>>>>>>>>>>>> Architecture@wso2.org >>>>>>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Thanks & Regards, >>>>>>>>>>>> >>>>>>>>>>>> *Johann Dilantha Nallathamby* >>>>>>>>>>>> Senior Lead Solutions Engineer >>>>>>>>>>>> WSO2, Inc. >>>>>>>>>>>> lean.enterprise.middleware >>>>>>>>>>>> >>>>>>>>>>>> Mobile - *+94777776950* >>>>>>>>>>>> Blog - *http://nallaa.wordpress.com >>>>>>>>>>>> <http://nallaa.wordpress.com>* >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Gayan Gunawardana >>>>>>>>>>> Senior Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>>>>>>> Email: ga...@wso2.com >>>>>>>>>>> Mobile: +94 (71) 8020933 >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Gayan Gunawardana >>>>>>>>>> Senior Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>>>>>> Email: ga...@wso2.com >>>>>>>>>> Mobile: +94 (71) 8020933 >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Gayan Gunawardana >>>>>>>> Senior Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>>>> Email: ga...@wso2.com >>>>>>>> Mobile: +94 (71) 8020933 >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> *Johann Dilantha Nallathamby* >>>>>>> Senior Lead Solutions Engineer >>>>>>> WSO2, Inc. >>>>>>> lean.enterprise.middleware >>>>>>> >>>>>>> Mobile - *+94777776950* >>>>>>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks & Regards, >>>>>> >>>>>> *Johann Dilantha Nallathamby* >>>>>> Senior Lead Solutions Engineer >>>>>> WSO2, Inc. >>>>>> lean.enterprise.middleware >>>>>> >>>>>> Mobile - *+94777776950* >>>>>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Godwin Amila Shrimal* >>>>> Associate Technical Lead >>>>> WSO2 Inc.; http://wso2.com >>>>> lean.enterprise.middleware >>>>> >>>>> mobile: *+94772264165* >>>>> linkedin: *https://www.linkedin.com/in/godwin-amila-2ba26844/ >>>>> <https://www.linkedin.com/in/godwin-amila-2ba26844/>* >>>>> twitter: https://twitter.com/godwinamila >>>>> <http://wso2.com/signature> >>>>> >>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> >>>> *Johann Dilantha Nallathamby* >>>> Senior Lead Solutions Engineer >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> >>>> Mobile - *+94777776950* >>>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>>> >>> >>> >>> >>> -- >>> *Godwin Amila Shrimal* >>> Associate Technical Lead >>> WSO2 Inc.; http://wso2.com >>> lean.enterprise.middleware >>> >>> mobile: *+94772264165* >>> linkedin: *https://www.linkedin.com/in/godwin-amila-2ba26844/ >>> <https://www.linkedin.com/in/godwin-amila-2ba26844/>* >>> twitter: https://twitter.com/godwinamila >>> <http://wso2.com/signature> >>> >> >> >> >> -- >> Thanks & Regards, >> >> *Johann Dilantha Nallathamby* >> Senior Lead Solutions Engineer >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - *+94777776950* >> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >> > > > > -- > *Godwin Amila Shrimal* > Associate Technical Lead > WSO2 Inc.; http://wso2.com > lean.enterprise.middleware > > mobile: *+94772264165* > linkedin: *https://www.linkedin.com/in/godwin-amila-2ba26844/ > <https://www.linkedin.com/in/godwin-amila-2ba26844/>* > twitter: https://twitter.com/godwinamila > <http://wso2.com/signature> > -- Thanks & Regards, *Johann Dilantha Nallathamby* Senior Lead Solutions Engineer WSO2, Inc. lean.enterprise.middleware Mobile - *+94777776950* Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>*
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
