On Fri, Nov 17, 2017 at 5:59 PM, Dilan Udara Ariyaratne <[email protected]> wrote:
> > It was possible to fix this remaining issue by accessing the manifest > variables in .erb files using the scope['variable'] notation [1] instead of > the existing @variable local scope notation [2]. > With this fix [3], we should now be able to successfully run WSO2 puppet > modules on top of puppet 5.x with minimal changes [4] that would be > compatible until the next puppet major release 6.0. > > Great work Dilan! As we discussed offline may be we can now move these changes to WSO2 Puppet repositories, including the Puppet Docker Compose script in the puppet-common repository and replace existing Vagrant script with that. Thanks Imesh > [1] - https://puppet.com/docs/puppet/5.3/lang_template_erb.html#sc > opevariable-or-scopelookupvarvariable > [2] - https://puppet.com/docs/puppet/5.3/lang_template_erb.html#variable > [3] - https://github.com/DilanUA/wso2-puppet-modules-5x-upgrade/co > mmit/a9b27970d2501d2ceb5cb424a11aa9f6a15966a3 > [4] - https://github.com/DilanUA/wso2-puppet-modules-5x-upgrade > > Thanks, > Dilan. > > -- *Imesh Gunaratne* WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 <+94%2077%20374%202057> W: https://medium.com/@imesh TW: @imesh lean. enterprise. middleware
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
