Hi,
Here is an experimental user import summery.
SUMMERY :
Bulk User Import Operation Performed by: admin
Duplicate user count: 8
Duplicate Users :
name1, name2, name74, name3, name3, name, name83, name5,
Failed User Count: 2 Failed Users:
Name : namsdsa
Cause : Invalid claim uri has been provided:
http://wso2.org/claims/ctry
Name : name2ssss
Cause : Invalid claim uri has been provided:
http://wso2.org/claims/emaiaddress
The cause string is the standard error which comes from the exception. Do
we need to print the stack trace here?
Also, there are two BulkUserImport classes (CSVUserBulkImport[1] and
ExcelUserBulkImport[2]) and also an unused interface [3] (The classes [1]
and [2] are concreet classes).
@IAM Team: Is there any particular reason why it kept like this?
IMO in this implementation, we could use it to avoid code and method
duplication. (By making it an Abstract class)
[1]
https://github.com/wso2/carbon-identity-framework/blob/master/components/user-mgt/org.wso2.carbon.user.mgt/src/main/java/org/wso2/carbon/user/mgt/bulkimport/CSVUserBulkImport.java
[2]
https://github.com/wso2/carbon-identity-framework/blob/master/components/user-mgt/org.wso2.carbon.user.mgt/src/main/java/org/wso2/carbon/user/mgt/bulkimport/ExcelUserBulkImport.java
[3]
https://github.com/wso2/carbon-identity-framework/blob/master/components/user-mgt/org.wso2.carbon.user.mgt/src/main/java/org/wso2/carbon/user/mgt/bulkimport/UserBulkImport.java
Thanks and Regards,
Menaka
On Mon, Mar 12, 2018 at 2:14 PM, Menaka Jayawardena <men...@wso2.com> wrote:
> [- strategy +Architecture]
>
>
> On Mon, Mar 12, 2018 at 12:21 PM, Menaka Jayawardena <men...@wso2.com>
> wrote:
>
>> Hi Dimuthu,
>>
>> Are you going to add this log appender by default to the configuration?
>>>
>> We can add the log appender by default and keep it commented. So when the
>> user enables the Bulk User import, he also can enable the log appender as
>> well.
>>
>>
>> On Mon, Mar 12, 2018 at 12:07 PM, Dimuthu Leelarathne <dimut...@wso2.com>
>> wrote:
>>
>>> Hi Menaka,
>>>
>>> Are you going to add this log appender by default to the configuration?
>>>
>>> thanks,
>>> Dimuthu
>>>
>>> On Mon, Mar 12, 2018 at 11:48 AM, Dakshika Jayathilaka <
>>> daksh...@wso2.com> wrote:
>>>
>>>> Hi Ruwan,
>>>>
>>>> Do we need to log each success? IMO admin will more interest on
>>>> failures or duplicates. IMHO we can add detail log on failures and
>>>> duplicates and then log the summary which includes the success count.
>>>>
>>>> WDYT?
>>>>
>>>> Regards,
>>>>
>>>> *Dakshika Jayathilaka*
>>>> PMC Member & Committer of Apache Stratos
>>>> Associate Technical Lead
>>>> WSO2, Inc.
>>>> lean.enterprise.middleware
>>>> 0771100911 <077%20110%200911>
>>>>
>>>> On Mon, Mar 12, 2018 at 11:35 AM, Ruwan Abeykoon <ruw...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi Menaka,
>>>>> This is nice feature.
>>>>> I would suggest adding one line per each user, before adding, and one
>>>>> line for each success, failure(with reason).
>>>>> Also add a line who performs this operation. Any trackable information
>>>>> of the request for audit purposes.
>>>>>
>>>>> Cheers,
>>>>> Ruwan
>>>>>
>>>>>
>>>>> On Mon, Mar 12, 2018 at 11:21 AM, Menaka Jayawardena <men...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Currently, when performing bulk user import operation in Identity
>>>>>> Server, users face following issues.
>>>>>>
>>>>>> 1. To check import failed users, need to filter the carbon log file.
>>>>>> 2. In UI, it shows only the last error that occurred when importing
>>>>>> users.
>>>>>>
>>>>>> *Requirement Description.*
>>>>>> There should be a user friendly way to view the import failed users.
>>>>>>
>>>>>> As a solution for this, we will provide a new log appender which will
>>>>>> log the messages to a separate log file specific for bulk user import.
>>>>>> This
>>>>>> will help users to easily view the status of the imported users and all
>>>>>> the
>>>>>> error logs.
>>>>>>
>>>>>> Also currently, as the operation summery, we only have
>>>>>>
>>>>>> "Success count: " + successCount + ", Fail count: " + failCount + ",
>>>>>> Duplicate count: " + duplicateCount
>>>>>>
>>>>>> Instead, it would be much effective if we could list the failed and
>>>>>> duplicate user names as well.
>>>>>>
>>>>>> "Success count: " + successCount + ", Fail count: " + failCount + ",
>>>>>> Duplicate count: " + duplicateCount
>>>>>> "Failed Users : " + [Failed Users List] + "Duplicate Users : " +
>>>>>> [Duplicate Users List]
>>>>>>
>>>>>> WDYT?
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Menaka
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Menaka Jayawardena*
>>>>>> *Software Engineer - WSO2 Inc*
>>>>>> *Tel : 071 350 5470 <071%20350%205470>*
>>>>>> *LinkedIn: https://lk.linkedin.com/in/menakajayawardena
>>>>>> <https://lk.linkedin.com/in/menakajayawardena>*
>>>>>> *Blog: https://menakamadushanka.wordpress.com/
>>>>>> <https://menakamadushanka.wordpress.com/>*
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> *Ruwan Abeykoon*
>>>>> *Associate Director/Architect**,*
>>>>> *WSO2, Inc. http://wso2.com <https://wso2.com/signature> *
>>>>> *lean.enterprise.middleware.*
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Dimuthu Leelarathne
>>> Director, Rapid Response Team
>>>
>>> WSO2, Inc. (http://wso2.com)
>>> email: dimut...@wso2.com
>>> Mobile: +94773661935 <+94%2077%20366%201935>
>>> Blog: http://muthulee.blogspot.com
>>>
>>> Lean . Enterprise . Middleware
>>>
>>
>>
>>
>> --
>> *Menaka Jayawardena*
>> *Software Engineer - WSO2 Inc*
>> *Tel : 071 350 5470*
>> *LinkedIn: https://lk.linkedin.com/in/menakajayawardena
>> <https://lk.linkedin.com/in/menakajayawardena>*
>> *Blog: https://menakamadushanka.wordpress.com/
>> <https://menakamadushanka.wordpress.com/>*
>>
>>
>
>
> --
> *Menaka Jayawardena*
> *Software Engineer - WSO2 Inc*
> *Tel : 071 350 5470*
> *LinkedIn: https://lk.linkedin.com/in/menakajayawardena
> <https://lk.linkedin.com/in/menakajayawardena>*
> *Blog: https://menakamadushanka.wordpress.com/
> <https://menakamadushanka.wordpress.com/>*
>
>
--
*Menaka Jayawardena*
*Software Engineer - WSO2 Inc*
*Tel : 071 350 5470*
*LinkedIn: https://lk.linkedin.com/in/menakajayawardena
<https://lk.linkedin.com/in/menakajayawardena>*
*Blog: https://menakamadushanka.wordpress.com/
<https://menakamadushanka.wordpress.com/>*
_______________________________________________
Architecture mailing list
Architecture@wso2.org
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
