To add bit more to what Ruwini has explained.. Universal widget currently reads the provider configuration and fetches data from the data source and render the vizgrammar chart using the fetched data according to the chart configuration. In the proposed approach we will still keep the provider configuration reading and fetching data related logic in the Universal Widget as it is and hand over the rendering to the specific rendering component based on the visual element type (i.e vizgrammer or search) And Universal widget + renderers will get packed as a single module instead of multiple modules based on visual element renderer since it will avoid the backward compatibility issue.
Thanks, Tanya On Fri, Sep 21, 2018 at 10:44 AM Ruwini Wijesiri <[email protected]> wrote: > Hi, > > If we use the name 'UniversalWidget' instead of 'ParentRenderer' as shown > below, it will eliminate the backward compatibility issue. > > > *-universal-widget* > > *-vizgrammar-renderer* > *-search-renderer* > > Appreciate your thoughts on this approach. > > Thanks, > Regards, > Ruwini > > On Fri, Sep 21, 2018 at 9:50 AM Ruwini Wijesiri <[email protected]> wrote: > >> Hi Sajith, >> >> Thanks for the response. >> >> I'll proceed with this approach. >> >> Thanks, >> Regards, >> Ruwini >> >> On Fri, Sep 21, 2018 at 9:44 AM Sajith Ariyarathna <[email protected]> >> wrote: >> >>> +1 for 2nd approach. >>> +1 for suggested migration implementation. >>> >>> Thanks. >>> >>> On Fri, Sep 21, 2018 at 9:38 AM Ruwini Wijesiri <[email protected]> wrote: >>> >>>> Hi Tanya, >>>> >>>> Thank you for the response. >>>> >>>> I think its better to handle this at the dashboard level by making " >>>>> *UniversalWidget*" a reserved word and replacing it with " >>>>> *vizgrammar-renderer" *in the Dashboard json before passing it to >>>>> Golden Layout. So that customers don't need to bother about any additional >>>>> migration effort. >>>>> >>>> >>>> +1 for this. >>>> >>>> Thanks, >>>> Regards, >>>> Ruwini. >>>> >>>> On Fri, Sep 21, 2018 at 8:37 AM Tanya Madurapperuma <[email protected]> >>>> wrote: >>>> >>>>> +1 for the second approach. >>>>> >>>> >>>> >>>> -- >>>> Ruwini Wijesiri >>>> Software Engineer, >>>> WSO2 Inc. >>>> >>>> Mobile : +94716133480 >>>> >>>> <http://wso2.com/signature> >>>> >>> >>> >>> -- >>> Sajith Janaprasad Ariyarathna >>> Senior Software Engineer; WSO2, Inc.; http://wso2.com/ >>> <https://wso2.com/signature> >>> >> >> >> -- >> Ruwini Wijesiri >> Software Engineer, >> WSO2 Inc. >> >> Mobile : +94716133480 >> >> <http://wso2.com/signature> >> > > > -- > Ruwini Wijesiri > Software Engineer, > WSO2 Inc. > > Mobile : +94716133480 > > <http://wso2.com/signature> > -- *Tanya Madurapperuma* | Associate Technical Lead| WSO2 Inc. (m) +94718184439 | (e) [email protected] <http://wso2.com/signature>
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
