Hi Frank,

As we support PUT operation on all the sub-resources of the
/identity-provider, we decided to support PATCH operation only for the root
level attributes of IDP.. e.g IDP name, certificate etc. Please find the
updated swagger definition in [1]. IMO, it is not convenient to ask the
user to send a PUT request to update a frequently updated attribute such as
IDP certificate. WDYT?

[1] https://app.swaggerhub.com/apis/emswbandara/IAM_IDP/0.1.0-oas3

On Sat, Nov 2, 2019 at 7:00 PM Frank Leymann <[email protected]> wrote:

> Hi Sathya,
>
> you support PATCH for the
> resource /identity-providers/{identity-provider-id}  but for none of the
> other resources: any reason for this?  Don't get me wrong, the less we
> support PATCH the better ;-)
>
> Best regards,
> Frank
>
>
>
>
> Am Sa., 2. Nov. 2019 um 06:24 Uhr schrieb Sathya Bandara <[email protected]
> >:
>
>> Hi all,
>>
>> WSO2 Identity Server currently supports IDP related operations using SOAP
>> APIs. I'm currently working on introducing a REST API layer for IDP
>> management in 5.10.0. Please find the API definition in [1].
>>
>> The internal implementation for the above APIs will use the
>> IdentityProviderManager[2] OSGi service. As per the team discussions, we
>> have introduced the following framework level changes to support RESTful
>> operations for the IDPs.
>>
>>    - Introduce UUID, Image URL to identity provider model.
>>    - Change DDL of IDP table to store UUID and Image URL.
>>    - Introduce Regex, Options and SubProperties to Property model.
>>    - Introduce OSGi methods and DAO layer methods to do IDP operations
>>    with resource ID (UUID).
>>    - Listeners for IDP operations based on resource ID.
>>
>> [1] https://app.swaggerhub.com/apis/emswbandara/IAM_IDP/0.1.0
>>
>> Highly appreciate your valuable suggestions.
>>
>> Thanks,
>> Sathya
>> --
>> Sathya Bandara
>> Senior Software Engineer
>> Blog: https://medium.com/@technospace
>> WSO2 Inc. http://wso2.com
>> Mobile: (+94) 715 360 421
>>
>> <+94%2071%20411%205032>
>> _______________________________________________
>> Architecture mailing list
>> [email protected]
>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>
> _______________________________________________
> Architecture mailing list
> [email protected]
> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>


-- 
Sathya Bandara
Senior Software Engineer
Blog: https://medium.com/@technospace
WSO2 Inc. http://wso2.com
Mobile: (+94) 715 360 421

<+94%2071%20411%205032>
_______________________________________________
Architecture mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture

Reply via email to