Hi Chamila, On Tue, Jul 14, 2020 at 12:28 PM Chamila Adhikarinayake <[email protected]> wrote:
> > > Hi Malintha, > >> 3. The last successful commit will be stored in a special config file >> (vcs_config.yaml) that resides in <user_home>/.wso2apictl folder. This will >> have per-repo > per-environment last successful commit. Whenever there are >> new commits, the last successful commit will be used to identify the >> changes. >> >> > Regarding this approach, There are possibilities that we might not be able > to find changes based on the last stored commit because of some git > features. (Ex: rebasing, amending , > https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History). Wouldn't > there be an issue when identifying the changes due to these things? > Thanks for raising this. Yes. If we rewrite history, that'll be an issue. However, I think, rewriting git history is rarely done in an organization. Even in our repositories (master branches), we hardly ever allow that. If someone needs to do it in an unavoidable situation, they will have to manually edit the stored commit to a correct one in the vcs_config file. Thanks! > > *Issues to be sorted:* >> 1. vcs_config.yaml is containing a state (last successful commit). In a >> typical CICD flow, there should be a way to preserve this file to use when >> the next build comes. In a single VM, it will not be an issue, but during >> other platforms like k8s, need to identify if there are any issues, etc. >> >> I am working on incorporating this into the APICTL 3.2.0 release. >> >> Your suggestions are most welcome. >> >> Thanks! >> Malintha >> >> >> -- >> Malintha Amarasinghe >> *WSO2, Inc. - lean | enterprise | middleware* >> http://wso2.com/ >> >> Mobile : +94 712383306 >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> > > > -- > Regards, > Chamila Adhikarinayake > Associate Technical Lead > WSO2, Inc. > Mobile - +94712346437 > Email - [email protected] > Blog - http://helpfromadhi.blogspot.com/ > -- Malintha Amarasinghe *WSO2, Inc. - lean | enterprise | middleware* http://wso2.com/ Mobile : +94 712383306
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
