Since we already have a working, fully tested traffic manager running on siddhi 3.x and we don't need any new siddhi features for the traffic manager to work, why do we migrate to a newer version and break it? I feel we should stay in the current range and port the required component to 3.x . Based on Tishan's reply seems like it is not a complex task.
On Mon, Sep 14, 2020 at 6:27 PM Praminda Jayawardana <[email protected]> wrote: > Hi All, > > IMO its best to migrate to siddhi 5.x.x with the next major APIM version. > So we can properly handle any breaking changes to TM. > > Thanks, > Praminda > > On Mon, Sep 14, 2020 at 5:58 PM Chashika Weerathunga <[email protected]> > wrote: > >> Hi all, >> >> Thank you very much for the information @Nirushan @chamila, @Tishan & >> @Fazlan. This will be really helpful for me. I will consider the above >> information when I migrating the siddhi version to 5.x.x in Traffic Manager. >> >> Thanks & Regards >> >> On Mon, Sep 14, 2020 at 4:47 PM Fazlan Nazeem <[email protected]> wrote: >> >>> I also feel that it's the right time to move to the new siddhi version >>> now itself as we will have enough time to test before the next release. >>> However, it is not only the execution plans which need consideration. >>> >>> 1. We are making use of the JMS topic for various use cases in APIM like >>> token revocation etc. These work via event publishers and the current >>> file-based publisher mechanism will not work. I guess these will also need >>> new siddhi apps. >>> 2. We need to think about custom execution plans deployed by customers. >>> These will have to be migrated to new syntax via some mechanism during the >>> migration process. >>> >>> >>> On Mon, Sep 14, 2020 at 4:05 PM Tishan Dahanayakage <[email protected]> >>> wrote: >>> >>>> Hi all, >>>> >>>> If we consider pros and cons >>>> *Option 01:* >>>> Pros: >>>> - Future proof as TM is currently using old components >>>> - TM deployment will be simpler(SP based) >>>> Cons: >>>> - More effort as we need to migrate everything >>>> - Need comprehensive testing >>>> >>>> *Option 02:* >>>> Pros: >>>> - Less development overhead(You will be able to port core part of the >>>> impl as it is) >>>> >>>> Cons: >>>> - Will need to upgrade to the latest Siddhi at some point in the >>>> future. Hence will be a wasted effort at that point. >>>> >>>> Thanks, >>>> Tishan >>>> >>>> On Mon, Sep 14, 2020 at 3:38 PM Niruhan Viswarupan <[email protected]> >>>> wrote: >>>> >>>>> It should be possible to implement grpc io for Siddhi 3.2.3 based on >>>>> the current siddhi-io-grpc extension code. However, this will require some >>>>> effort and maintenance of a new repo branch. >>>>> >>>>> I don't have adequate knowledge on breaking API changes between siddhi >>>>> 3.2.3 and 5.X.X w.r.t extensions. Maybe @Mohanadarshan >>>>> Vivekanandalingam <[email protected]> or @Tishan Dahanayakage >>>>> <[email protected]> can advise further on this >>>>> >>>>> On Mon, Sep 14, 2020 at 2:52 PM Chamila Adhikarinayake < >>>>> [email protected]> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Mon, Sep 14, 2020 at 12:44 PM Chashika Weerathunga < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> >>>>>>> We are planning to implement a gRPC data receiver for the throttling >>>>>>> in APIM Traffic Manager. >>>>>>> >>>>>>> Currently, the Trafic manager can receive data through thrift and >>>>>>> binary protocols. But to be compatible with Envoy Micirogateway, we >>>>>>> need to >>>>>>> implement a gRPC data receiver. >>>>>>> >>>>>>> >>>>>>> Currently in Traffic Manager, it uses siddhi 3.2.3 version. But >>>>>>> existing siddhi gRPC extension ( >>>>>>> https://github.com/siddhi-io/siddhi-io-grpc >>>>>>> <https://github.com/siddhi-io/siddhi-io-grpc>) supports only 4.x.x >>>>>>> version onwards. >>>>>>> >>>>>>> >>>>>>> Considering the above reasons we have two options to implement the >>>>>>> gRPC data receiver for the Traffic manager. >>>>>>> >>>>>>> >>>>>>> 1. Migrating Traffic Manager siddhi version to the newest version >>>>>>> and use the existing siddhi gRPC extension. >>>>>>> >>>>>> >>>>>> If we migrate to the latest siddhi version, we will have to migrate >>>>>> the existing throttling policies as well. AFAIR this was one of the >>>>>> reasons >>>>>> for staying in the 3.x version. >>>>>> >>>>>> >>>>>>> 2. Implement a gRPC support for the 3.x.x version. >>>>>>> >>>>>>> >>>>>>> Git issue: https://github.com/wso2/product-apim/issues/9259 >>>>>>> >>>>>>> >>>>>>> I'm planning to go with option 1 since it will be much effective >>>>>>> than option 2. But there can be pros and cons between these two options >>>>>>> >>>>>>> >>>>>>> It will be really appreciated if you have any thoughts and advice >>>>>>> regarding this. >>>>>>> >>>>>>> >>>>>>> >>>>>>> Thank you >>>>>>> >>>>>>> Best regards >>>>>>> >>>>>>> -- >>>>>>> *Chashika Weerathunga* | Software Engineer | WSO2 Inc. >>>>>>> (m) +94713731206 | Email: [email protected] >>>>>>> [image: http://wso2.com] >>>>>>> <http://wso2.com> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Chamila Adhikarinayake >>>>>> Associate Technical Lead >>>>>> WSO2, Inc. >>>>>> Mobile - +94712346437 >>>>>> Email - [email protected] >>>>>> Blog - http://helpfromadhi.blogspot.com/ >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Niruhan Viswarupan* >>>>> Software Engineer | WSO2 Inc. <http://wso2.com/> >>>>> (M)+94 776468013 | (E) [email protected] >>>>> LinkedIn <https://www.linkedin.com/in/niruhan/> | GitHub >>>>> <https://github.com/niruhan> | Medium <https://medium.com/@niruhan> >>>>> >>>>> >>>> >>>> -- >>>> *Tishan Dahanayakage* | Technical Lead | WSO2 Inc. >>>> (m) +94716481328 | (w) +94112145345 | (e) [email protected] >>>> GET INTEGRATION AGILE >>>> Integration Agility for Digitally Driven Business >>>> <http://wso2.com/signature> >>>> Disclaimer: This communication may contain privileged or other >>>> confidential information and is intended exclusively for the addressee/s. >>>> If you are not the intended recipient/s, or believe that you may have >>>> received this communication in error, please reply to the sender indicating >>>> that fact and delete the copy you received and in addition, you should not >>>> print, copy, re-transmit, disseminate, or otherwise use the information >>>> contained in this communication. Internet communications cannot be >>>> guaranteed to be timely, secure, error or virus-free. The sender does not >>>> accept liability for any errors or omissions. >>>> >>> >>> >>> -- >>> Thanks & Regards, >>> >>> *Fazlan Nazeem | *Associate Technical Lead | WSO2 Inc >>> Mobile : +94772338839 | [email protected] >>> >>> >>> >> >> -- >> *Chashika Weerathunga* | Software Engineer | WSO2 Inc. >> (m) +94713731206 | Email: [email protected] >> >> -- >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> <[email protected]> >> >> *Praminda Jayawardana* | Associate Technical Lead | WSO2 Inc. >> <[email protected]> >> (e) <[email protected]>[email protected] >> >> [image: http://wso2.com/signature] <http://wso2.com/signature> >> GET INTEGRATION AGILE >> Integration Agility for Digitally Driven Business >> > -- Regards, Chamila Adhikarinayake Associate Technical Lead WSO2, Inc. Mobile - +94712346437 Email - [email protected] Blog - http://helpfromadhi.blogspot.com/
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
