Author: brett
Date: Sat Sep 9 08:51:32 2006
New Revision: 441803
URL: http://svn.apache.org/viewvc?view=rev&rev=441803
Log:
clarify some TODO elements
Modified:
maven/archiva/trunk/archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java
maven/archiva/trunk/archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java
maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java
maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java
maven/archiva/trunk/archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp
Modified:
maven/archiva/trunk/archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java
URL:
http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java?view=diff&rev=441803&r1=441802&r2=441803
==============================================================================
---
maven/archiva/trunk/archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java
(original)
+++
maven/archiva/trunk/archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java
Sat Sep 9 08:51:32 2006
@@ -97,7 +97,7 @@
private void scheduleJobs( Configuration configuration )
throws ParseException, SchedulerException
{
- // TODO! would be nice to queue jobs that are triggered so we could
avoid two running at the same time (so have a queue for discovery based jobs so
they didn't thrash the repo)
+ // TODO: would be nice to queue jobs that are triggered so we could
avoid two running at the same time (so have a queue for discovery based jobs so
they didn't thrash the repo)
if ( configuration.getIndexPath() != null )
{
JobDetail jobDetail = createJobDetail( INDEXER_JOB, indexerTask );
@@ -107,7 +107,7 @@
new CronTrigger( INDEXER_JOB + "Trigger", DISCOVERER_GROUP,
configuration.getIndexerCronExpression() );
scheduler.scheduleJob( jobDetail, trigger );
- // TODO: run as a job so it doesn't block startup/configuration
saving!
+ // TODO: run as a job so it doesn't block startup/configuration
saving
try
{
indexerTask.executeNowIfNeeded();
Modified:
maven/archiva/trunk/archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java
URL:
http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java?view=diff&rev=441803&r1=441802&r2=441803
==============================================================================
---
maven/archiva/trunk/archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java
(original)
+++
maven/archiva/trunk/archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java
Sat Sep 9 08:51:32 2006
@@ -264,7 +264,7 @@
File versionsDir =
new File( repository.getBasedir(),
repository.pathOfRemoteRepositoryMetadata( metadata ) ).getParentFile();
- // TODO! I don't know how this condition can happen, but it was seen
on the main repository.
+ // TODO: I don't know how this condition can happen, but it was seen
on the main repository.
// Avoid hard failure
if ( versionsDir.exists() )
{
Modified:
maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java
URL:
http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java?view=diff&rev=441803&r1=441802&r2=441803
==============================================================================
---
maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java
(original)
+++
maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java
Sat Sep 9 08:51:32 2006
@@ -58,7 +58,7 @@
artifactStream = new FileInputStream( file );
- // TODO: could be better!
+ // TODO: set the correct content type and other headers!
contentType = "application/octet-stream";
filename = file.getName();
Modified:
maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java
URL:
http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java?view=diff&rev=441803&r1=441802&r2=441803
==============================================================================
---
maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java
(original)
+++
maven/archiva/trunk/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java
Sat Sep 9 08:51:32 2006
@@ -43,6 +43,6 @@
protected void removeContents( AbstractRepositoryConfiguration
existingRepository )
throws IOException
{
- // TODO!
+ // TODO! remove the contents
}
}
Modified:
maven/archiva/trunk/archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp
URL:
http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp?view=diff&rev=441803&r1=441802&r2=441803
==============================================================================
---
maven/archiva/trunk/archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp
(original)
+++
maven/archiva/trunk/archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp
Sat Sep 9 08:51:32 2006
@@ -74,7 +74,7 @@
<ww:url action="proxy">
<%-- TODO! create a tag for this, include classifier for javadoc,
sources below --%>
<%-- TODO: what about other repositories? --%>
- <%-- TODO! extension probably doesn't match type --%>
+ <%-- TODO! extension probably doesn't match type. Use artifact handler
instead. --%>
<ww:param name="path"
value="%{'${model.groupId}/${model.artifactId}/${model.version}/${model.artifactId}-${model.version}.${model.packaging}'}"/>
</ww:url>
