svn commit: r574898 - in /maven/archiva/trunk: archiva-base/archiva-proxy/src/test/java/org/apache/maven/archiva/proxy/ archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/repositories/

[brett]

Author: brett
Date: Wed Sep 12 04:57:08 2007
New Revision: 574898

URL: http://svn.apache.org/viewvc?rev=574898&view=rev
Log:
[MRM-144] clean up TODOs

Modified:
    
maven/archiva/trunk/archiva-base/archiva-proxy/src/test/java/org/apache/maven/archiva/proxy/ManagedDefaultTransferTest.java
    
maven/archiva/trunk/archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/repositories/ConfigureRepositoryAction.java

Modified: 
maven/archiva/trunk/archiva-base/archiva-proxy/src/test/java/org/apache/maven/archiva/proxy/ManagedDefaultTransferTest.java
URL: 
http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/archiva-proxy/src/test/java/org/apache/maven/archiva/proxy/ManagedDefaultTransferTest.java?rev=574898&r1=574897&r2=574898&view=diff
==============================================================================
--- 
maven/archiva/trunk/archiva-base/archiva-proxy/src/test/java/org/apache/maven/archiva/proxy/ManagedDefaultTransferTest.java
 (original)
+++ 
maven/archiva/trunk/archiva-base/archiva-proxy/src/test/java/org/apache/maven/archiva/proxy/ManagedDefaultTransferTest.java
 Wed Sep 12 04:57:08 2007
@@ -338,7 +338,7 @@
         wagonMockControl.verify();
         assertNoTempFiles( expectedFile );
 
-        // TODO: do not want failures to present as a not found!
+        // TODO: do not want failures to present as a not found [MRM-492]
         // TODO: How much information on each failure should we pass back to 
the user vs. logging in the proxy? 
     }
 

Modified: 
maven/archiva/trunk/archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/repositories/ConfigureRepositoryAction.java
URL: 
http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/repositories/ConfigureRepositoryAction.java?rev=574898&r1=574897&r2=574898&view=diff
==============================================================================
--- 
maven/archiva/trunk/archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/repositories/ConfigureRepositoryAction.java
 (original)
+++ 
maven/archiva/trunk/archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/repositories/ConfigureRepositoryAction.java
 Wed Sep 12 04:57:08 2007
@@ -234,7 +234,10 @@
         if ( !file.exists() )
         {
             file.mkdirs();
-            // TODO: error handling when this fails, or is not a directory!
+        }
+        if ( !file.exists() || !file.isDirectory() )
+        {
+            throw new IOException( "unable to add repository - can not create 
the root directory: " + file );
         }
 
         configuration.addManagedRepository( repository );