Re: svn commit: r585583 - in /maven/archiva/trunk/archiva-reporting/archiva-artifact-reports/src/main/java/org/apache/maven/archiva/reporting/artifact: DuplicateArtifactsConsumer.java LocationArtifactsConsumer.java

Wed, 17 Oct 2007 13:29:00 -0700 


On 18/10/2007, at 3:23 AM, [EMAIL PROTECTED] wrote:


@@ -294,13 +294,14 @@
     {
         try
         {
- BidirectionalRepositoryLayout layout = layoutFactory.getLayout( artifact ); 
-            return layout.toPath( artifact );
+            String repoId = artifact.getModel().getRepositoryId();
+ ManagedRepositoryContent repo = repositoryFactory.getManagedRepositoryContent( repoId ); 
+            return repo.toPath( artifact );
         }
-        catch ( LayoutException e )
+        catch ( RepositoryException e )
         {
getLogger().warn( "Unable to calculate path for artifact: " + artifact ); 
-            return null;
+            return "";
         }
Is that really an appropriate response to a request for a path, or will this expect the caller to do some error handling on the empty string?
Also - the commit seems to be spread out across multiple revisions again - what tooling are you using? 

- Brett

--
Brett Porter - [EMAIL PROTECTED]
Blog: http://www.devzuz.org/blogs/bporter/

Reply via email to