Heya Kevin,

Thanks for bringing this up.  I took a quick look at the code, and I see what’s 
going on here.  I’m going to put in a pull request later today to hopefully 
patch this in the upcoming release.  That “found in” column was one of the 
first feature enhancements I tackled, so I’m afraid there are some edge cases 
(such as what to do in instances of suppressed records) that I just didn’t 
consider/test out, and our pre-release testing didn’t catch it either.  If you 
have the ability/are able to test this out before it makes it to an official 
release, I’m happy to send you a build with this fix in it to test out locally. 
 Feel free to reach out off-list if you’d like.

Best,

Lora

From: <archivesspace_users_group-boun...@lyralists.lyrasis.org> on behalf of 
Kevin Clair <kevin.cl...@du.edu>
Reply-To: Archivesspace Users Group 
<archivesspace_users_group@lyralists.lyrasis.org>
Date: Thursday, April 25, 2019 at 12:37 PM
To: Archivesspace Users Group <archivesspace_users_group@lyralists.lyrasis.org>
Subject: Re: [Archivesspace_Users_Group] Suppressed record search bug

We’re on 2.5.2 now. We upgraded because of that bug; that’s why I thought the 
problem could be with the event record instead of the resource.  -k

From: <archivesspace_users_group-boun...@lyralists.lyrasis.org> on behalf of 
Blake Carver <blake.car...@lyrasis.org>
Reply-To: Archivesspace Group <archivesspace_users_group@lyralists.lyrasis.org>
Date: Thursday, April 25, 2019 at 10:28 AM
To: Archivesspace Group <archivesspace_users_group@lyralists.lyrasis.org>
Subject: Re: [Archivesspace_Users_Group] Suppressed record search bug

What version are you on? That looks similar to a bug that should've been fixed 
in 2.5.2.
________________________________
From: archivesspace_users_group-boun...@lyralists.lyrasis.org 
<archivesspace_users_group-boun...@lyralists.lyrasis.org> on behalf of Kevin 
Clair <kevin.cl...@du.edu>
Sent: Thursday, April 25, 2019 12:08 PM
To: Archivesspace Users Group
Subject: Re: [Archivesspace_Users_Group] Suppressed record search bug


I should also say that the search that prompted this also returns a 
component_transfer event of records that were moved from the suppressed 
Resource to another Resource. So it may be that it’s an issue with suppressed 
records appearing in the “Found In” column of another record’s result summary, 
rather than with the suppressed record itself…  -k



From: <archivesspace_users_group-boun...@lyralists.lyrasis.org> on behalf of 
Kevin Clair <kevin.cl...@du.edu>
Reply-To: Archivesspace Group <archivesspace_users_group@lyralists.lyrasis.org>
Date: Thursday, April 25, 2019 at 10:00 AM
To: Archivesspace Group <archivesspace_users_group@lyralists.lyrasis.org>
Subject: [Archivesspace_Users_Group] Suppressed record search bug



Hello,



We recently discovered an issue with searching for records that are suppressed 
in the staff interface. In our instance, administrative users are able to do 
known-item searches for suppressed records without incident; if a user without 
administrative permissions performs the same search, they get thrown an error 
with the following stack trace:



I, [2019-04-25T09:47:26.038804 #18125]  INFO -- : Completed 500 Internal Server 
Error in 1163ms

F, [2019-04-25T09:47:26.041948 #18125] FATAL -- :

F, [2019-04-25T09:47:26.042069 #18125] FATAL -- : ActionView::Template::Error 
(undefined method `[]' for nil:NilClass):

F, [2019-04-25T09:47:26.042263 #18125] FATAL -- :     1: <% ancestors = 
context_ancestor(result) %>

    2: <% if ancestors != nil && ancestors != [''] %>

    3:   <% ancestors.reverse.each_with_index do |ancestor, i| %>

    4:     <%= 
resolve_readonly_link_to((get_ancestor_title(ancestor).html_safe), ancestor) %>

    5:     <% if i < ancestors.length - 1 %>

    6:       <%= context_separator(result) %>

    7:     <% end %>

F, [2019-04-25T09:47:26.042340 #18125] FATAL -- :

F, [2019-04-25T09:47:26.042413 #18125] FATAL -- : 
app/helpers/search_helper.rb:198:in `get_ancestor_title'

app/views/search/_context.html.erb:4:in `block in 
_app_views_search__context_html_erb___234296763_2752'

app/views/search/_context.html.erb:3:in 
`_app_views_search__context_html_erb___234296763_2752'

app/helpers/application_helper.rb:289:in `render_aspace_partial'

app/views/search/_listing.html.erb:90:in `block in 
_app_views_search__listing_html_erb___1981573825_2748'

app/views/search/_listing.html.erb:52:in 
`_app_views_search__listing_html_erb___1981573825_2748'

app/helpers/application_helper.rb:289:in `render_aspace_partial'

app/views/search/_results.html.erb:23:in 
`_app_views_search__results_html_erb___1135689531_2744'

app/helpers/application_helper.rb:289:in `render_aspace_partial'

app/views/search/do_search.html.erb:16:in 
`_app_views_search_do_search_html_erb__585907251_2742'



Checking in to see if anyone else has noticed similar behavior and if there’s a 
bug report for this in Jira already. I did a quick search just now but couldn’t 
find anything that looked similar to this. thanks!  -k
_______________________________________________
Archivesspace_Users_Group mailing list
Archivesspace_Users_Group@lyralists.lyrasis.org
http://lyralists.lyrasis.org/mailman/listinfo/archivesspace_users_group

Reply via email to