Hi all,

Further to this exchange, I've come back to this work and have been doing some 
local testing to try and get the locales to display correctly. It turns out 
that commenting this line out seems to fix my issue perfectly: 
https://github.com/archivesspace/archivesspace/blob/a37fcedd610505e633abdc68694ccda75cb756a3/public/config/initializers/locales.rb#L2
[https://opengraph.githubassets.com/48d750ff7e0824367b77ecaa74384386367d08d4ad8958a12dc6d6477c79554a/archivesspace/archivesspace]<https://github.com/archivesspace/archivesspace/blob/a37fcedd610505e633abdc68694ccda75cb756a3/public/config/initializers/locales.rb#L2>
archivesspace/locales.rb at a37fcedd610505e633abdc68694ccda75cb756a3 · 
archivesspace/archivesspace<https://github.com/archivesspace/archivesspace/blob/a37fcedd610505e633abdc68694ccda75cb756a3/public/config/initializers/locales.rb#L2>
The ArchivesSpace archives management tool. Contribute to 
archivesspace/archivesspace development by creating an account on GitHub.
github.com
I don't really understand why this is working (the locales in question don't 
have entries in any frontend files) but I'd like to move this change to a 
development environment to investigate further. I can't see how to use a plugin 
to stop this reordering from running - might anyone have any suggestions?

Many thanks,
Nick
________________________________
From: [email protected] 
<[email protected]> on behalf of Nick 
Butler <[email protected]>
Sent: 31 March 2022 09:55
To: [email protected] 
<[email protected]>
Subject: Re: [Archivesspace_Users_Group] PUI locales not being fully loaded in 
v3.1.1?

Hi Andrew,

Thanks for your reply. That doesn't appear to be the case here (either in my 
dockerised local development environment, where this is my only active plugin, 
or in our development server, where there are no other public/locale/*​ files 
in any of our other currently-loaded plugins). Thanks for pointing that commit 
out, it looks like the related PR 
(https://github.com/archivesspace/archivesspace/pull/2266<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Farchivesspace%2Farchivesspace%2Fpull%2F2266&data=04%7C01%7Cnpwb2%40universityofcambridgecloud.onmicrosoft.com%7C6ddd14faa83a41deaad908da12f43496%7C49a50445bdfa4b79ade3547b4f3986e9%7C0%7C0%7C637843138269353601%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8Xm%2Fh19A0vMNPyY4NH1Wb%2FyZU%2BeRsLx39%2B69QT3M2lU%3D&reserved=0>)
 made a number of other changes to plugins as well. I'll take a closer look.

Many thanks,
Nick
[https://opengraph.githubassets.com/4f0a13a1a5b8753a7c5f583c5b46fc83586f0f61767e88e9effaef05c794c08a/archivesspace/archivesspace/pull/2266]<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Farchivesspace%2Farchivesspace%2Fpull%2F2266&data=04%7C01%7Cnpwb2%40universityofcambridgecloud.onmicrosoft.com%7C6ddd14faa83a41deaad908da12f43496%7C49a50445bdfa4b79ade3547b4f3986e9%7C0%7C0%7C637843138269353601%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8Xm%2Fh19A0vMNPyY4NH1Wb%2FyZU%2BeRsLx39%2B69QT3M2lU%3D&reserved=0>
Hm plugin enhancements from #1896 by lorawoodford · Pull Request #2266 · 
archivesspace/archivesspace<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Farchivesspace%2Farchivesspace%2Fpull%2F2266&data=04%7C01%7Cnpwb2%40universityofcambridgecloud.onmicrosoft.com%7C6ddd14faa83a41deaad908da12f43496%7C49a50445bdfa4b79ade3547b4f3986e9%7C0%7C0%7C637843138269353601%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8Xm%2Fh19A0vMNPyY4NH1Wb%2FyZU%2BeRsLx39%2B69QT3M2lU%3D&reserved=0>
Includes 30 commits from the larger #1896 written by @marktriggs @jambun 
@payten and funded by Queensland State Archives. 3dc860a: Introduce 
AbstractPluginSection (and examples) to allow arbitrar...
github.com

________________________________
From: [email protected] 
<[email protected]> on behalf of Andrew 
Morrison <[email protected]>
Sent: 31 March 2022 08:54
To: [email protected] 
<[email protected]>
Subject: Re: [Archivesspace_Users_Group] PUI locales not being fully loaded in 
v3.1.1?


Do you have two or more plug-ins with a public/locale/en.yml file in each? If 
they have both have a brand: section, then one will override the other, even if 
only one defines a translation for the title: variable.


There has been a change between 2.8.1 and 3.1.1 in how plug-ins are loaded:


https://github.com/archivesspace/archivesspace/commit/1f4f34dd7cc655fc4a6e6d68cd8a5d8ff8c35cf8<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Farchivesspace%2Farchivesspace%2Fcommit%2F1f4f34dd7cc655fc4a6e6d68cd8a5d8ff8c35cf8&data=04%7C01%7Cnpwb2%40universityofcambridgecloud.onmicrosoft.com%7C6ddd14faa83a41deaad908da12f43496%7C49a50445bdfa4b79ade3547b4f3986e9%7C0%7C0%7C637843138269353601%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=I2bZqcMfwfn3HaaMztU5kzexM%2FElIUnbCJWwgohSLe0%3D&reserved=0>


Andrew.



On 30/03/2022 15:10, Nick Butler wrote:
Hi all,

We've been trying out ArchivesSpace v3.1.1 in development environments prior to 
upgrading our production system from v2.8.1. We're experiencing an issue 
whereby some of the entries in our local plugin's public/locales/en.yml​ file 
seemingly aren't being recognised. As far as I can tell, anything that's 
intended to override an entry in the default file isn't being seen (i.e. the 
value of brand.title​) , but everything new (i.e. entries in a plugins​ block) 
is being loaded successfully. Using ArchivesSpace version v2.8.1 again, without 
making any other changes, makes the locales load as expected. All entries in 
the plugin's frontend/locales/en.yml​ file are being respected as expected in 
both v2.8.1 and v3.1.1. Has anyone else experienced this?

Many thanks,
Nick



_______________________________________________
Archivesspace_Users_Group mailing list
[email protected]<mailto:[email protected]>
http://lyralists.lyrasis.org/mailman/listinfo/archivesspace_users_group<https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Flyralists.lyrasis.org%2Fmailman%2Flistinfo%2Farchivesspace_users_group&data=04%7C01%7Cnpwb2%40universityofcambridgecloud.onmicrosoft.com%7C6ddd14faa83a41deaad908da12f43496%7C49a50445bdfa4b79ade3547b4f3986e9%7C0%7C0%7C637843138269353601%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=o8TVNfcg33VHd030ug7K5wqkfKF2naom2%2FkTEUnCOxI%3D&reserved=0>

_______________________________________________
Archivesspace_Users_Group mailing list
[email protected]
http://lyralists.lyrasis.org/mailman/listinfo/archivesspace_users_group

Reply via email to