Hey Forrest
I took a look at the sample and have some suggestions for you :-).
First (and I do know this is trivial) it doesn't compile, I'm sure this
is just a typo but it would be good to fix it. The problem is duplicate
package statements in PersonIdVerifierSimpleImpl.java.
The second issue is that you have the interface mixed in with the
implementation - this is not best (OSGi ) practice. The interface should
be in a separate bundle, have a look at the blog-sample and helloworld
sample to see how this is done . This may seem a small point but I think
any samples we have should demonstrate not only how to do things but the
best way to do them.
Thirdly, I think the sample should be
org.apache.aries.samples.blueprint.whatever-you-want, where
'whatever-you-want' is maybe 'inlined-managers'?
Finally - rather than asking the user to collect up all the platform
bundles that you need to run the code, how about doing it automatically
using Maven as we have with the hello-world and blog samples?
How do you feel about making these changes? I'd be happy to put it into
SVN if you made them.
Zoe
Hi Zoe,
Could you please help look at this new blueprint sample contribution jira?
And see if it is ok as an Aries sample to demonstrate blueprint usage?
In this sample, a multiple-nesting inlined managers are adopted. I think it
might be helpful for newbie to learn how to use inlined managers.
If there is anything need to improve or modify, pls just let me know.
Thanks!
Forrest
---------- Forwarded message ----------
From: Forrest Xia (JIRA) <[email protected]>
Date: Wed, Dec 30, 2009 at 8:47 PM
Subject: [jira] Updated: (ARIES-100) Another blueprint sample to contribute
To: [email protected]
[
https://issues.apache.org/jira/browse/ARIES-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
Forrest Xia updated ARIES-100:
------------------------------
Attachment: blueprint-complexsample.zip
Another blueprint sample to contribute
--------------------------------------
Key: ARIES-100
URL: https://issues.apache.org/jira/browse/ARIES-100
Project: Aries
Issue Type: Improvement
Components: Blueprint
Affects Versions: Incubation
Reporter: Forrest Xia
Attachments: blueprint-complexsample.zip
These days I am testing blueprint MBean, and generated a complex blueprint
sample. With this sample, user can learn how to define nesting components
with blueprint XML.
To run this sample, besides OSGi framework, these bundles are required:
CoreOptions.mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.configadmin").versionAsInProject(),
CoreOptions.mavenBundle().groupId("org.apache.felix").artifactId("org.apache.felix.eventadmin").versionAsInProject(),
CoreOptions.mavenBundle().groupId("org.ops4j.pax.logging").artifactId("pax-logging-api").versionAsInProject(),
CoreOptions.mavenBundle().groupId("org.ops4j.pax.logging").artifactId("pax-logging-service").versionAsInProject(),
CoreOptions.mavenBundle().groupId("org.apache.aries.blueprint").artifactId("org.apache.aries.blueprint").versionAsInProject(),
CoreOptions.mavenBundle().groupId("org.apache.aries").artifactId("org.apache.aries.util"),
CoreOptions.mavenBundle().groupId("org.apache.aries.jmx").artifactId("aries-jmx-blueprint").versionAsInProject(),
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
