OK, plugin is all yours. I really hope you don't invent some new conventions for dependency handling that are different from what all the other maven packaging plugins do. I just copied what the rar plugin does, I haven't checked whether it is consistent with the war and ear plugins.

good luck
david jencks

On Feb 26, 2010, at 10:11 AM, Graham Charters wrote:

Thanks Joe/Jeremy.  Irrespective of this, I think the default
behaviour should be to not include transitive dependencies.
Unfortunately, I've failed in tidying up what i've done and getting
the plugin tests clean.  They make assumptions about things like
source directory and manifest.mf being part of the plugin and in the
zip based version, they're not.  I'll hopefully get this sorted over
the weekend.

Regards, Graham.

On 26 February 2010 17:10, Jeremy Hughes <[email protected]> wrote:
On 26 February 2010 16:20, Joe Bohn <[email protected]> wrote:
It looks like there are changes afoot to this plugin but just thought I'd confirm that it produces something equivalent to what I was producing for
AriesTrader and the result works equally as well.

I think the transitive dependencies referenced by Graham can be fixed if the blog sample is updated to specify a scope of provided on the dependencies. For AriesTrader I use that scope for all external dependencies and I didn't
have any unexpected dependencies included in the EBA generated for
AriesTrader.

One of those dependencies was derby which wasn't marked with a scope
so has picked up the default 'compile' scope. Scope of provided will
make the classes available on the compile classpath which isn't even
needed. The scope would need to be 'test' if there was actually a test
case! So I think we can just remove the dependency of derby (in this
case).


Joe


David Jencks wrote:

I think it works.... contents look similar to what was generated
previously. I attached a patch to ARIES-120 for ariestrader-all- eba in case
anyone wants to take a closer look or try deploying it.

thanks
david jencks

On Feb 25, 2010, at 6:25 PM, David Jencks wrote:

I adapted the maven-rar-plugin to do what I think an eba-maven- plugin ought to do and put it under application. Right now it's not tied into the build. It may need to move elsewhere in the tree to make it easier to use in aries itself, building and using plugins in the same build can be tricky.

So far you need to write the application.mf yourself and put it in the
source project under src/main/eba/META-INF/application.mf

To use it your project needs to have

<packaging>eba</packaging>

and configure the plugin with

  <build>
      <plugins>
          <plugin>
              <groupId>org.apache.aries.application</groupId>
              <artifactId>eba-maven-plugin</artifactId>
              <version>1.0.0-incubating-SNAPSHOT</version>
              <extensions>true</extensions>
              <configuration>
                  <includeJar>false</includeJar>
              </configuration>
          </plugin>
      </plugins>
  </build>

Note the very required extensions element.
By default it builds a jar from the java files in the project and
installs it in the eba.  The above configures it not to do that.

I haven't tried this on a real eba yet... if anyone can try that and see if the results work that would be great. I'll probably try tomorrow if no
one gets there first.

thanks
david jencks





--
Joe



Reply via email to