On 26 February 2010 18:12, David Jencks <[email protected]> wrote: > > On Feb 26, 2010, at 9:40 AM, Jeremy Hughes wrote: > >> On 26 February 2010 17:24, Joe Bohn <[email protected]> wrote: >>> >>> Just a clarification - it isn't in "the" target dir ... it is in a >>> directory >>> named target which is under src/test/resources/unit/basic-eba-test. In >>> general though, I would prefer to not have a directory named "target" >>> anywhere in our source. (which will let my hack work again ;-) ). >> >> Ah yes, I missed that. You should change your hack :-) But it is still >> confusing and I would prefer not to have a subdir called target under >> src > > I copied this from a rar plugin unit test. I think its a pretty reasonable > way to have a test fixture for a packaging mojo. I'm not changing it, if > you want to jump through hoops to create the same test situation go ahead. > I think the result will be unmaintainable.
OK, sounds like there is precedent and even probably this is the best thing to do. So I take it back - I'll get used to it. > > thanks > david jencks > > > >> >>> >>> Joe >>> >>> >>> Guillaume Nodet wrote: >>>> >>>> Agreed. Having stuff in the target dir is just plain wrong imho. >>>> >>>> On Fri, Feb 26, 2010 at 18:07, Jeremy Hughes <[email protected]> wrote: >>>>> >>>>> Yeah, this looks strange to me too. I don't think we should have >>>>> anything in the target dir of any module in SVN. Can we have it in >>>>> src/test/resources then move it over to target as part of the build. >>>>> >>>>> Jeremy >>>>> >>>>> On 26 February 2010 16:28, Joe Bohn <[email protected]> wrote: >>>>>> >>>>>> This change exposed a problem with a hack that I've been using for a >>>>>> long >>>>>> time and I thought I should get some recommendations. >>>>>> >>>>>> For a while now (like years) I've been cleaning out my mvn builds >>>>>> using >>>>>> a >>>>>> custom script rather than "mvn clean". I had problems at one point in >>>>>> the >>>>>> past where "mvn clean" didn't really clean up everything ... but >>>>>> simply >>>>>> finding and removing all "target" directories did a great job (and was >>>>>> even >>>>>> faster than "mvn clean"). However, this change caused me some grief >>>>>> because >>>>>> when I ran my script to purge all "target" directories after this >>>>>> change >>>>>> I >>>>>> removed some important source files. >>>>>> >>>>>> So that leads to the following questions: >>>>>> 1) Is my hack really bad and should I never use it again? >>>>>> 2) Do we want to name source files with "target" in the path when >>>>>> target >>>>>> has >>>>>> a special meaning in maven builds and is often set to be ignored? >>>>>> >>>>>> Regards, >>>>>> Joe >>>>>> >>>>>> >>>>>> [email protected] wrote: >>>>>>> >>>>>>> Author: djencks >>>>>>> Date: Fri Feb 26 02:17:38 2010 >>>>>>> New Revision: 916538 >>>>>>> >>>>>>> URL: http://svn.apache.org/viewvc?rev=916538&view=rev >>>>>>> Log: >>>>>>> ARIES-120 add a couple missing test files >>>>>>> >>>>>>> Added: >>>>>>> >>>>>>> >>>>>>> >>>>>>> incubator/aries/trunk/application/eba-maven-plugin/src/test/resources/unit/basic-eba-test/target/ >>>>>>> >>>>>>> >>>>>>> >>>>>>> incubator/aries/trunk/application/eba-maven-plugin/src/test/resources/unit/basic-eba-test/target/test-eba.jar >>>>>>> (with props) >>>>>>> >>>>>>> Added: >>>>>>> >>>>>>> >>>>>>> incubator/aries/trunk/application/eba-maven-plugin/src/test/resources/unit/basic-eba-test/target/test-eba.jar >>>>>>> URL: >>>>>>> >>>>>>> >>>>>>> http://svn.apache.org/viewvc/incubator/aries/trunk/application/eba-maven-plugin/src/test/resources/unit/basic-eba-test/target/test-eba.jar?rev=916538&view=auto >>>>>>> >>>>>>> >>>>>>> >>>>>>> ============================================================================== >>>>>>> Binary file - no diff available. >>>>>>> >>>>>>> Propchange: >>>>>>> >>>>>>> >>>>>>> incubator/aries/trunk/application/eba-maven-plugin/src/test/resources/unit/basic-eba-test/target/test-eba.jar >>>>>>> >>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> svn:mime-type = application/java-archive >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> Joe >>>>>> >>>> >>>> >>>> >>> >>> >>> -- >>> Joe >>> > >
