Hi, I did notice that and that made me even more confused as to why they were moved.
I'm not sure I fully understand what you are trying to do, but can you not just use the application runtime for basic support? Also is you rely on the OBR resolver then you are unlikely to work with the NoOpResolver. Also the NoOpResolver doesn't properly implement the spec for the interface. Alasdair On 15 March 2010 15:13, Jarek Gawor <[email protected]> wrote: > Alasdair, > > I see you already reverted this change.... but just to be clear: I > moved these classes but not the xml bits. So yes, everybody will get > the NoOpResolver/DefaultLocalPlatform classes but they don't get > automatically used just because they are available in the > application-utils module. I don't think having these classes in the > application-utils creates any problems or confusion since it's clear > from their names or javadoc what they do or do not do. I also found > them useful when implementing the Application API in Geronimo. I > didn't have to implement two more interfaces just to get a basic > application support going. I'm also pretty sure the NoOpResolver might > come useful when debugging and somebody wants to disable their OBR > resolver temporarily. > > Jarek > > On Fri, Mar 12, 2010 at 6:48 PM, Alasdair Nottingham <[email protected]> wrote: >> I'm not so sure about moving the NoOpResolver to the util bundle. It >> isn't something I would encourage people to consume and having it in >> util will mean everyone gets it, which could cause it to be chosen >> over say the OBR resolver. >> >> Alasdair >> >> On 12 March 2010 18:30, <[email protected]> wrote: >>> Author: gawor >>> Date: Fri Mar 12 18:30:33 2010 >>> New Revision: 922381 >>> >>> URL: http://svn.apache.org/viewvc?rev=922381&view=rev >>> Log: >>> ARIES-238: move NoOpResolver and DefaultLocalPlatform to application-utils >>> >>> Added: >>> >>> incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/DefaultLocalPlatform.java >>> (contents, props changed) >>> - copied, changed from r922335, >>> incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/DefaultLocalPlatform.java >>> >>> incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/NoOpResolver.java >>> (contents, props changed) >>> - copied, changed from r922335, >>> incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/NoOpResolver.java >>> Removed: >>> >>> incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/DefaultLocalPlatform.java >>> >>> incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/NoOpResolver.java >>> Modified: >>> >>> incubator/aries/trunk/application/application-runtime/src/main/resources/OSGI-INF/blueprint/app-context-management.xml >>> >>> Modified: >>> incubator/aries/trunk/application/application-runtime/src/main/resources/OSGI-INF/blueprint/app-context-management.xml >>> URL: >>> http://svn.apache.org/viewvc/incubator/aries/trunk/application/application-runtime/src/main/resources/OSGI-INF/blueprint/app-context-management.xml?rev=922381&r1=922380&r2=922381&view=diff >>> ============================================================================== >>> --- >>> incubator/aries/trunk/application/application-runtime/src/main/resources/OSGI-INF/blueprint/app-context-management.xml >>> (original) >>> +++ >>> incubator/aries/trunk/application/application-runtime/src/main/resources/OSGI-INF/blueprint/app-context-management.xml >>> Fri Mar 12 18:30:33 2010 >>> @@ -28,8 +28,8 @@ >>> <!-- Default implementations of services that must be implemented against >>> a >>> particular application server environment follow --> >>> >>> - <bean id="default-local-platform" >>> class="org.apache.aries.application.runtime.defaults.DefaultLocalPlatform"/> >>> - <bean id="no-op-resolver" >>> class="org.apache.aries.application.runtime.defaults.NoOpResolver"/> >>> + <bean id="default-local-platform" >>> class="org.apache.aries.application.utils.management.DefaultLocalPlatform"/> >>> + <bean id="no-op-resolver" >>> class="org.apache.aries.application.utils.management.NoOpResolver"/> >>> >>> <service interface="org.apache.aries.application.management.LocalPlatform" >>> ref="default-local-platform" >>> >>> Copied: >>> incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/DefaultLocalPlatform.java >>> (from r922335, >>> incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/DefaultLocalPlatform.java) >>> URL: >>> http://svn.apache.org/viewvc/incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/DefaultLocalPlatform.java?p2=incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/DefaultLocalPlatform.java&p1=incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/DefaultLocalPlatform.java&r1=922335&r2=922381&rev=922381&view=diff >>> ============================================================================== >>> --- >>> incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/DefaultLocalPlatform.java >>> (original) >>> +++ >>> incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/DefaultLocalPlatform.java >>> Fri Mar 12 18:30:33 2010 >>> @@ -16,7 +16,7 @@ >>> * specific language governing permissions and limitations >>> * under the License. >>> */ >>> -package org.apache.aries.application.runtime.defaults; >>> +package org.apache.aries.application.utils.management; >>> >>> import java.io.File; >>> import java.io.IOException; >>> >>> Propchange: >>> incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/DefaultLocalPlatform.java >>> ------------------------------------------------------------------------------ >>> svn:mergeinfo = >>> >>> Copied: >>> incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/NoOpResolver.java >>> (from r922335, >>> incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/NoOpResolver.java) >>> URL: >>> http://svn.apache.org/viewvc/incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/NoOpResolver.java?p2=incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/NoOpResolver.java&p1=incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/NoOpResolver.java&r1=922335&r2=922381&rev=922381&view=diff >>> ============================================================================== >>> --- >>> incubator/aries/trunk/application/application-runtime/src/main/java/org/apache/aries/application/runtime/defaults/NoOpResolver.java >>> (original) >>> +++ >>> incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/NoOpResolver.java >>> Fri Mar 12 18:30:33 2010 >>> @@ -16,7 +16,7 @@ >>> * specific language governing permissions and limitations >>> * under the License. >>> */ >>> -package org.apache.aries.application.runtime.defaults; >>> +package org.apache.aries.application.utils.management; >>> >>> import java.util.Set; >>> >>> >>> Propchange: >>> incubator/aries/trunk/application/application-utils/src/main/java/org/apache/aries/application/utils/management/NoOpResolver.java >>> ------------------------------------------------------------------------------ >>> svn:mergeinfo = >>> >>> >>> >> >> >> >> -- >> Alasdair Nottingham >> [email protected] >> > -- Alasdair Nottingham [email protected]
