Sounds sensible to me. I will adhere to the convention henceforth.

On 7 Apr 2010, at 13:32, Joe Bohn wrote:


I hope this doesn't sound too nit-picky ... but it is generally good practice at Apache to give attribution to the person that provided the patch when committing code. This helps when considering people for commit authority. It is also helpful to have a brief description of the change. In my opinion something like this would be a better commit message:

ARIES-271 Ensure thread pools use daemon threads - patch by Brian DePradine

Joe

[email protected] wrote:
Author: mahrwald
Date: Wed Apr  7 09:20:32 2010
New Revision: 931474
URL: http://svn.apache.org/viewvc?rev=931474&view=rev
Log:
ARIES-271 Integrate patch

<snip/>

Reply via email to