[ 
https://issues.apache.org/jira/browse/ARIES-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857341#action_12857341
 ] 

Lin Sun commented on ARIES-272:
-------------------------------

Hi Holly

Thanks for the file.  I have only one comment -

In the InternalRecursiveBundleTracker, in customizedProcessBundle line 123, the 
code calls opentracker when bundle states is installed or starting.  In the 
case of bundle state installed, in line 149, the code has 

    BundleContext compositeBundleContext = 
cb.getCompositeFramework().getBundleContext();

Would you be able to get a valid compositeBundleContext here when the composite 
is installed but not starting or started yet?


Lin

> BundleTrackerCustomizers will not recurse on bundles added to a 
> CompositeBundle before the composite bundle is started
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: ARIES-272
>                 URL: https://issues.apache.org/jira/browse/ARIES-272
>             Project: Aries
>          Issue Type: Improvement
>            Reporter: Holly Cummins
>         Attachments: aries272.patch, InternalRecursiveBundleTracker.java
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> At the moment the AbstractBundleTrackerCustomizer and its descendents trap 
> Bundle.STARTING events. If the originator is a composite bundle they add 
> themselves as a tracker to the composite bundle's context so that they are 
> notified of bundle events in the child framework. This model assumes that the 
> child bundles are added to the composite bundle *after* it is started. It 
> would be better to trap Bundle.INSTALLED events, since child bundles can be 
> added any time after the composite bundle is installed. For example, if the 
> composite bundle has exports, its children have to be added *before* it is 
> started so that it can satisfy the exports.
> There is also quite a lot of  redunant and duplicate code in the area of the 
> bundle tracker customizers which should be cleaned up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to