On 23 April 2010 18:42, David Jencks <[email protected]> wrote: > +1 > > All the source zips build into something reasonable looking (modulo test > failures in transaction) > Legal files pass my limited scrutiny :-) > > thanks > david jencks > > On Apr 23, 2010, at 10:24 AM, Jeremy Hughes wrote: > >> On 23 April 2010 18:07, David Jencks <[email protected]> wrote: >>> I'm fine with belatedly requiring java 6 and continuing the vote after >>> application is staged to an additional staging repo. >> >> We wouldn't be belatedly requiring java 6, because of these issues we >> would be requiring java 6 in this release. I've uploaded the >> application modules and they are available here: >> > > I said "belatedly" because this was not stated clearly as a prerequisite and > the poms lead one to think java 5 is sufficient.
Ok sorry I misunderstood. Thanks for the +1 > >> https://repository.apache.org/content/repositories/orgapachearies-015/ >> >> Please consider the modules in this repository a part of the release. >> The release continues to depend on Java 6. >> >>> >>> thanks >>> david jencks >>> >>> On Apr 23, 2010, at 7:19 AM, Joe Bohn wrote: >>> >>>> On 4/23/10 10:06 AM, Jeremy Hughes wrote: >>>>> On 23 April 2010 13:54, Lin Sun<[email protected]> wrote: >>>>>> I was under the impression that we have to build aries using 1.6, >>>>>> otherwise we would get compile error. >>>>> >>>>> This is true. There is a problem with the ConnectionWrapper class in >>>>> transaction-wrappers. It implements java.sql.Connection. That >>>>> interface had methods added to it in java 1.6 which have new classes >>>>> on their signatures ...e.g. NClob. So either ConnectionWrapper needs >>>>> java 6 or it needs java 5 but it can't be written to use both ... >>>>> unless we do some fancy trickery with dynamic proxies. >>>>> >>>>> Is having java 6 as a prereq a problem for anyone? >>>> >>>> I was already assuming that it was a prereq. >>>> >>>> Joe >>>> >>>> >>>>> >>>>>> >>>>>> In any way, we do want to specify/check in the root pom that the >>>>>> required level of JDK is used but I don't think this is a stop ship >>>>>> issue. >>>>>> >>>>>> Lin >>>>>> >>>>>> On Fri, Apr 23, 2010 at 6:39 AM, Jeremy Hughes<[email protected]> >>>>>> wrote: >>>>>>> On 23 April 2010 11:14, Jeremy Hughes<[email protected]> wrote: >>>>>>>> On 22 April 2010 21:12, Alan D. Cabrera<[email protected]> wrote: >>>>>>>>> I tried to build this under JDK 1.5 and got compilation errors. >>>>>>>>> Should we >>>>>>>>> not have a compiler check in the POM? >>>>>>>> >>>>>>>> I was using 1.6. Trying again with 1.5 the first compile error I get >>>>>>>> is in 'util' because a method on IOException introduced in 1.6 is >>>>>>>> being used. Although we use: >>>>>>>> >>>>>>>> <plugin> >>>>>>>> <groupId>org.apache.maven.plugins</groupId> >>>>>>>> <artifactId>maven-compiler-plugin</artifactId> >>>>>>>> <configuration> >>>>>>>> <source>1.5</source> >>>>>>>> <target>1.5</target> >>>>>>>> </configuration> >>>>>>>> </plugin> >>>>>>>> >>>>>>>> in the pom that doesn't mean we get the 1.5 libraries. Since we want >>>>>>>> users to be able to use 1.5, I'll need to respin. >>>>>>> >>>>>>> So, I was just thinking of ways to ensure the we use jdk 1.5. Here's >>>>>>> one way: >>>>>>> >>>>>>> http://maven.apache.org/plugins/maven-compiler-plugin/examples/compile-using-different-jdk.html >>>>>>> >>>>>>> Which works for me: java -version gives me 1.6 and then building >>>>>>> org.apache.aries.util-0.1-incubating gives the IOException compile >>>>>>> problem. >>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Alan >>>>>>>>> >>>>>>>>> On Apr 22, 2010, at 10:39 AM, Jeremy Hughes wrote: >>>>>>>>> >>>>>>>>>> I've staged the second release candidate for Aries (Incubating) v0.1. >>>>>>>>>> The following Aries top level modules are staged and tagged in >>>>>>>>>> https://svn.apache.org/repos/asf/incubator/aries/tags/ at revision >>>>>>>>>> 936975. >>>>>>>>>> >>>>>>>>>> Modules staged at >>>>>>>>>> >>>>>>>>>> https://repository.apache.org/content/repositories/orgapachearies-009/ >>>>>>>>>> >>>>>>>>>> are: >>>>>>>>>> >>>>>>>>>> parent >>>>>>>>>> eba-maven-plugin >>>>>>>>>> testsupport >>>>>>>>>> util >>>>>>>>>> blueprint >>>>>>>>>> jndi >>>>>>>>>> transaction >>>>>>>>>> web >>>>>>>>>> application >>>>>>>>>> jmx >>>>>>>>>> jpa >>>>>>>>>> samples >>>>>>>>>> >>>>>>>>>> The RAT and IANAL bulid checks passed. >>>>>>>>>> >>>>>>>>>> The vote will be open for 72 hours. >>>>>>>>>> >>>>>>>>>> [ ] +1 >>>>>>>>>> [ ] +0 >>>>>>>>>> [ ] -1 >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Jeremy >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Joe >>> >>> > >
