My comments in <jarek></jarek>. On Wed, Jun 2, 2010 at 1:13 PM, Timothy Ward <[email protected]> wrote: > > Hi Jarek, > > I'd first like to say, thank you for looking at the JPA component and adding > new features. It isn't my intention to prevent you from using or enhancing > any of the aries code. I simply missed the background for the features and so > didn't have an opportunity to share any of the pre-existing design of the JPA > bundles. The reason I'm speaking up now is simply to try to make sure that we > keep a consistent approach with the code even though different people are > working on it.
<jarek>No problem. I should have started a discussion about the stuff I was planning to do</jarek> > > The existing plug point in the PersistenceBundleManager allows for the > ManagedPersistenceUnitFactory to be replaced with a different implementation, > returning customized ManagedPersistenceUnitInfo instances. We attempt to read > the name of the ManagedPersistenceUnitFactory implementation from a > properties file called org.apache.aries.jpa.container.properties, and we > expect the property key to be > org.apache.aries.jpa.container.ManagedPersistenceUnitFactory <jarek>I see that now and I totally missed it. I try this plug point and if it works I'll revert my Listener and/or Agent stuff</jarek> > There are comments as documentation in the ManagedPersistenceUnitFactory > interface, as well as a few references in the PersistenceBundleManager, but I > agree it would be better to put something up on the website too. > > > > Our expectation was that plugins could be written as fragments to the jpa > container bundle, including the properties file to set their > ManagedPersistenceUnitFactory. As a fragment it is possible to export > additional, plug-in specific, interfaces (e.g. the listener ortransformer) so > that implementors only resolve if the fragment is active. It is also possible > to subclass the existing ManagedPersistenceUnit* classes so that only a few > methods have to be reimplemented. > > > > I believe that the java agent weaving support is probably best added through > a fragment. Most users will not be running with a java agent, so I'd rather > it wasn't provided by the core jpa container or API bundles, but I do think > it's a good idea to have the support available in the Aries JPA project. > Perhaps there should be a common JPA extensions fragment in Aries? <jarek>The Listener or Agent stuff doesn't provide any functionality just extension points... but yes I think it would be useful to have something like that in Aries</jarek> Jarek
