[
https://issues.apache.org/jira/browse/ARIES-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887926#action_12887926
]
Jarek Gawor commented on ARIES-192:
-----------------------------------
I don't think this patch really addressed the problem. The only reason the
included test was passing was that the DummyConverter was rewriting the entire
eba file with the updated war file with the proper manifest information. The
test should only be generating and returning the updated war file.
There are actually two main problems here: 1) The ManifestDefaultsInjector
includes only valid bundles in the Application-Content header. So it might
generate incomplete header if the eba contains non-bundles such as war files.
The Application-Content should really be built based on extraBundlesInfo
created in AriesApplicationManagerImpl.createApplication() since it will
contains info for regular and converted bundles. 2) The extraBundlesInfo will
not actually contain the right information for any converted bundles. That is
because the BundleInfo created for the converted bundle is actually created
with the manifest information of the source/unconverted file (I already
mentioned this problem in point #2 in ARIES-257 a while ago). It should be
using the manifest from the converted bundle and therefore there should be a
call somewhere to BundleConversion.getBundleInfo().
> Convert bundles before generating the application content
> ---------------------------------------------------------
>
> Key: ARIES-192
> URL: https://issues.apache.org/jira/browse/ARIES-192
> Project: Aries
> Issue Type: Bug
> Components: Application
> Reporter: Alasdair Nottingham
> Assignee: Mark Nuttall
> Attachments: management.diff
>
>
> We currently convert by value artefacts after generating the
> Application-Content which means we will not pull in converted artefacts when
> no Application-Content is provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
