On 11/11/10 13:10, Sebastian Pipping wrote:
Stuart,


I have three questions/comments on the build systems.  Maybe this is
something that you you still want in 8.6.3:


On "make install"
^^^^^^^^^^^^^^^^^
Without these previous calls (mentioned in INSTALL.txt) make install
fails:

    # python a2x.py -f manpage doc/asciidoc.1.txt
    # python a2x.py -f manpage doc/a2x.1.txt

What are the reasons to not integrate this into the Makefile so make
install actually depends on them so that they get executed?
Would you accept patches for this?

I don't think there is a reason, please post a patch if you can come up with 
one.




Generation of file BUGS
^^^^^^^^^^^^^^^^^^^^^^^
The files four files README, BUGS, INSTALL, and CHANGELOG seem to be
shipped with tarballs only.  I was not able to find out, how you
generate these files.  What commands do you run?  Could you add a make
target for it?  It is of interested for building packages right from a
mercurial checkout.

These files are generated by the ./doc/main.aap build script (http://code.google.com/p/asciidoc/source/browse/doc/main.aap), they are generated by the %.text rule (AsciiDoc source to HTML then converted to text with lynx(1)).

I have thought about converting the AAP scripts to GNU Make so that all building is handled by Make but it would be a big job with no functional payoff.




Variable "manpdir" in Makefile.in
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Could it be that this line can be remove from Makefile.in?

   manpdir = $(mandir)/man1

I dont see $(manpdir) used anywhere.

I think it's just cruft so I've taken it out.


Cheers, Stuart



Best,



Sebastian


--
You received this message because you are subscribed to the Google Groups 
"asciidoc" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/asciidoc?hl=en.

Reply via email to