On 1 March 2011 22:56, haad <[email protected]> wrote:
>
> Hi
>>
>> > Ok seems like reasonable description question is why, is this problem
>> > visible only in when I use -e and otherwise it works.
>>
>> Seems like -e doesn't do two pass config file loading.
>>
>> In some ways that makes sense, you get exactly what you asked for when
>> you turned off automatic config file handling.  You can try loading a
>> config file before the others defining the doctype attribute.
>>
>> @Stuart,
>>
>> An alternative would be to enable two pass config file loading for
>> only explicitly specified configs.
>>
>> Suggest line 5583 be load_conffiles(include=['attributes']) and line
>> 5619 be unindented one so the explicit conf files are always loaded.
>
> Attached diff fixes my problem for me. It would be great to have this
> resolved in
> HEAD.
>
> diff -r 7fa2dd2b0531 asciidoc.py
> --- a/asciidoc.py       Sun Feb 20 12:41:51 2011 +1300
> +++ b/asciidoc.py       Tue Mar 01 13:53:36 2011 +0200
> @@ -5580,7 +5580,7 @@
>                 config.load_file('asciidoc.conf', indir,
>
> include=['attributes','titles','specialchars'])
>         else:
> -            load_conffiles()
> +            load_conffiles(include=['attributes'])
>         document.update_attributes()
>         # Check the infile exists.
>         if infile != '<stdin>':
> @@ -5617,6 +5617,8 @@
>                 config.load_file(f + '.conf')
>                 config.load_file(f + '-' + document.backend +
> '.conf')
>             load_conffiles()
> +        else:
> +                       load_conffiles()
>         # Build outfile name.
>         if outfile is None:
>             outfile = os.path.splitext(infile)[0] + '.' +
> document.backend
>

Thanks for making a patch, I am on a machine where I can browse the
repository but can't try anything out.

The only comment I'd make is that the else clause you added does the
same as the end of the then clause, really all it needed was for the
line before to be moved out of the then clause :-)

Cheers
Lex

> --
> You received this message because you are subscribed to the Google Groups 
> "asciidoc" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to 
> [email protected].
> For more options, visit this group at 
> http://groups.google.com/group/asciidoc?hl=en.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"asciidoc" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/asciidoc?hl=en.

Reply via email to