On 10/05/11 20:37, Lionel Orry wrote:


Le mardi 10 mai 2011 10:30:26 UTC+2, Lex Trotman a écrit :

    On 10 May 2011 18:11, Lionel Orry <[email protected]> wrote:
     > Here it is, attached.
     >
     > I made it simple but clear enough to understand the whole line is 
dropped.
     >
     > I've not actually used the trace system before, but it's definitely cool 
and
     > easy to use!

    Yeah.

    I was thinking of also adding it to the SUBS_NAMES list as well so
    :trace: subs would show all the substitutions and the failed
    substitutions, what do you think?

I thought about it but eventually did not want to pollute more the traces for
all subs, that some people may already use regularly. I suppose Stuart is the
one who will decide/

    I don't know about the space in the trace name, but Stuart will decide
    when he adds it.

Well the fact is that it works perfectly because the regexp for 'trace type'
matching does not require a full-length matching, i.e. -a 'trace=dropped' or
even -a 'trace=drop' work fine. And it allows the message to be more
descriptive. If the space causes problems, we could replace 'dropped line' by
'dropped_line'. I'll let Stuart decide, again, if he wants to integrate the
functionality.

Thanks for the patch Lionel, I've committed it to the trunk:
http://code.google.com/p/asciidoc/source/detail?r=692520597d0a59eee7cecbe473fd3b18d33b7352

I've left it as 'dropped line' as this is in keeping with the other trace names (which I've finally got round to documenting).

Cheers, Stuart


    Cheers
    Lex

    PS would do it but I.m using a tablet pc without diff, thanks

No pb, it's a pleasure to contribute with my very humble knowledge :)

Lionel

--
You received this message because you are subscribed to the Google Groups
"asciidoc" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/asciidoc?hl=en.

--
You received this message because you are subscribed to the Google Groups 
"asciidoc" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/asciidoc?hl=en.

Reply via email to