Hi!
On Tue, Sep 20, 2011 at 11:28:47AM +1200, Stuart Rackham wrote:
> > Maybe you'll include graphviz-cmap in asciidoc distrib? Or, at least, help
> > me make it less ugly?
> If it's a drop-in replacement that adds the cmap feature but is otherwise
> compatible with the existing graphviz then submit a patch for putting it into
> the distribution.
Patch already "submitted" - it was attached few emails before:
https://groups.google.com/group/asciidoc/msg/4974abf970e710f4
And while it's a drop-in replacement, I think there are several
shortcomings which are better to fix before replace current plugin,
but I don't know python and asciidoc's conf files good enough for this.
- Default [graphviz-block] used [filter-image-blockmacro] from
asciidoc.conf, which in turn used [image-blockmacro] from backend, which
may be different for different backends. But I need to modify backend
output, so I've copy&paste from both asciidoc.conf and xhtml11.conf into
[graphviz-block] section. Which means, now output of graphviz filter
doesn't depend on backend and always output like for xhtml11 backend.
I've no idea is it possible to fix this without patching xhtml11.conf
and other backends with graphviz-specific code and attributes which also
sounds not really good.
- I've used external commands `sed` and `rm` for tasks, which probably can
be done using pure python code. Also, this isn't portable, and won't
work on windows at least (I've no idea is graphviz itself work on windows).
- As I mention in previous email, I probably hit some bug in asciidoc's
conf parsing code, and had to introduce {quot} attribute as workaround.
Probably there is better way to fix this.
--
WBR, Alex.
--
You received this message because you are subscribed to the Google Groups
"asciidoc" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/asciidoc?hl=en.
