On 20 June 2012 15:33, Stuart Rackham <[email protected]> wrote: > > > On 20/06/12 17:20, Lex Trotman wrote: >> >> On 20 June 2012 14:47, Wilhelm<[email protected]> wrote: >>> >>> Am 20.06.2012 01:59, schrieb Stuart Rackham: >>>> >>>> >>>> Thanks for the patch Lex, I've committed it to the trunk: >>>> >>>> >>>> >>>> https://code.google.com/p/asciidoc/source/detail?r=f139415803b0107f84cc61437c180f7262a56bda >>>> >>> >>> Now xml/pdf generation is ok, but in html5 now class=myrole is encluded. >>> >>> Did I miss something? >>> >> >> Hi, >> >> (x)html(5) from source highlight filter is pre-styled so external >> classes shouldn't be applied. If you really need to do something the >> output of source-highlight is in a<div class=listingblock><div >> class=content> which you should be able to detect with CSS. > > > For consistency I've pushed a commit that added the role to HTML backends > for the source highlighter. > > https://code.google.com/p/asciidoc/source/detail?r=2bdaa8fdf97bcff9173ee2e0e30a5c35ea16a253 > > On the subject of consistency, wouldn't it make more sense to put the > DocBook role in the programlisting element for both titled and untitled > listings (currently in the formalpara element for titled and programlisting > element for untitled)? >
Hi Stuart, I thought about that, then I thought you might have put it on the formalpara deliberately so it was the same as the standard listingblock in docbook45.conf and most other blocks in docbook45.conf have role on the outer element. Cheers Lex > > Cheers, Stuart > > > >> >> Cheers >> Lex >> >>> >>>> >>>> Cheers, Stuart >>>> >>>> On 19/06/12 22:45, Lex Trotman wrote: >>>>> >>>>> >>>>> [...] >>>>>> >>>>>> >>>>>> The "source" style sends it to the source filter, which doesn't >>>>>> properly use the role attribute for listings without a title. That'd >>>>>> be a bug :) >>>>>> >>>>> >>>>> Patch attached. >>>>> >>>>> Cheers >>>>> Lex >>>>> >>>> >>> >>> >>> -- >>> Wilhelm >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "asciidoc" group. >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]. >>> For more options, visit this group at >>> http://groups.google.com/group/asciidoc?hl=en. >>> >> > > -- > You received this message because you are subscribed to the Google Groups > "asciidoc" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/asciidoc?hl=en. > -- You received this message because you are subscribed to the Google Groups "asciidoc" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/asciidoc?hl=en.
