On 5 April 2014 17:43, John Goalby <[email protected]> wrote: > > > On Wednesday, March 26, 2014 4:17:19 PM UTC-7, Lex Trotman wrote: >> >> [...] >> > >> > I had this same issue today. Worked without --icons and failed with it. >> > >> > After some investigation it appears to be an issue in a2x where it isn't >> > encoding the manifest file as UTF-8. In my case I had a copyright >> > symbol >> > introduced through the docinfo.xml file. My fix was to alter the a2x >> > file >> > itself as detailed in this bug fix page for fedora: >> > >> > >> > https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20131202/1153359.html >> > >> > I checked the mercurial repository and it doesn't have this change. >> > >> > The essence of the change is this: >> > >> > import codecs >> > ... >> > def write_file(filename, data, mode='w', encoding='utf-8'): >> > f = codecs.open(filename, mode, encoding) >> > ... >> >> Hi John, >> >> That looks sensible, can make a pull request please. >> > > I did this (I think). I am not familiar with hg. I created a clone, > changed on local, tested, and pushed. I see it on my cloned repository. > > https://code.google.com/r/jgoalby-writefileencodingissue/ > > But, I am not sure if that is the end of what I need to do, or if there is > another step to request that my changes be merged?
Erm, ummm, ahh, oops, Asciidoc is now using github at https://github.com/asciidoc/asciidoc, but since Stuarts retirement we havn't been able to change the website to mention that. I should have mentioned github of course. :) The reason for asking for a pull request for such a trivial change is that I'm mostly using a non-development machine ATM, so no Git. Changes would therefore take a long time as they must wait until I get a chance to use the dev machine, and by then they can get forgotten. But pull requests won't get forgotten, and I can use the big green button to commit things this simple by inspection. Cheers Lex > >> >> Cheers >> Lex >> >> PS a pox upon the house of Fedora/Redhat for not submitting it upstream :( >> > > :-) > > John. > >> >> >> > >> > The above worked for me. I think you should try and report back whether >> > it >> > worked for you. Perhaps then if it works we can suggest that it be >> > fixed? >> > >> > John. >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups >> > "asciidoc" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> > an >> > email to [email protected]. >> > To post to this group, send email to [email protected]. >> > Visit this group at http://groups.google.com/group/asciidoc. >> > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "asciidoc" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/asciidoc. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "asciidoc" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/asciidoc. For more options, visit https://groups.google.com/d/optout.
