The file test/compile-asdf.lisp catches compiler style warnings to avoid them being counted. However this would not appear to be
necessary as the third result of 'compile-file would seem to be just what is needed to catch warnings (excluding style-warnings) and
errors. Many CL implementations have style-warning handlers that show useful context and it would seem better to just leave it to
the implementation to handle. Possible patch attached.
Regards
Douglas Crosher
diff --git a/test/compile-asdf.lisp b/test/compile-asdf.lisp
index 1b150ec..2f2df0e 100644
--- a/test/compile-asdf.lisp
+++ b/test/compile-asdf.lisp
@@ -15,19 +15,11 @@
(let ((tmp (make-pathname :name "asdf-tmp" :defaults *asdf-fasl*)))
(ensure-directories-exist *asdf-fasl*)
(multiple-value-bind (result warnings-p errors-p)
- ;; style warnings shouldn't abort the compilation [2010/02/03:rpg]
- (handler-bind ((style-warning
- #'(lambda (w)
- (princ w *error-output*)
- (muffle-warning w))))
- (compile-file *asdf-lisp* :output-file tmp :print t :verbose t))
- (declare (ignore result))
+ (compile-file *asdf-lisp* :output-file tmp :print t :verbose t)
+ (declare (ignore result warnings-p))
(cond
- #-ecl ;; 10.7.1 from CVS has spurious warnings. Sigh.
- (warnings-p
- (leave-lisp "Testsuite failed: ASDF compiled with warnings" 1))
(errors-p
- (leave-lisp "Testsuite failed: ASDF compiled with ERRORS" 2))
+ (leave-lisp "Testsuite failed: ASDF compiled with warnings or
errors" 2))
(t
(when (probe-file *asdf-fasl*)
(delete-file *asdf-fasl*))
_______________________________________________
asdf-devel mailing list
[email protected]
http://common-lisp.net/cgi-bin/mailman/listinfo/asdf-devel
