Greetings -

I'm a newbie to Perl and - so much the more - Apache::ASP,
but when I needed <!--#include virtual=...-> support by
Apache::ASP, all I had to do is changing a couple of lines
in Apache/ASP.pm module. Here's the diff's output :

<DIFF_OUTPUT>
921c921
<     while($munge =~ s/^(.*?)\<!--\#include\s+(file|virtual)
\s*=\s*\"?([^\s\"]*?)\"?(\s+args\s*=\s*\"?.*?)?\"?\s*--\>//so) {
---
>     while($munge =~ s/^(.*?)\<!--\#include\s+file\s*=\s*\"?([^\s\"]
*?)\"?(\s+args\s*=\s*\"?.*?)?\"?\s*--\>//so) {
923c923
<  my $file = ($2 eq "virtual") ? $ENV{"DOCUMENT_ROOT"}.$3 : $3;
---
>  my $file = $2;
950c950
<  my $has_args = $4;
---
>  my $has_args = $3;
</DIFF_OUTPUT>

After that I restarted httpd and virtual inline includes began
working just fine.

The questions:

1. Does my implementation look too easy to be right?
2. Is it a "no-no" to modify the standard ASP.pm module?
3. Is there is a bug in my implementation of virtual includes?
4. Is there is a better, *right* implementation of virtual
   includes in Apache::ASP. If so then what is it?
5. If my implementation is good enough then how do I submit 
   a patch to the standard Apache::ASP distribution?

Thanks in advance

Constantine

   



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to