Re: $self->{asp} nor defined in Response?!

[Theo E. Schlossnagle]

Josh Chamas wrote:

This is when an old $Response object is no longer valid.  This is normally
caused by my closure or bad scoping issues.

I assumed as much. However, it seems that:
sub AppendToLog { shift->{asp}->Log(...); }
should bde
sub AppendToLog {
my $self = shift;
if($self && $self->{asp}) {
$self->{asp}->Log(...);
}
}

in Response.pm. Why? My $Response variable still exists and as I don't call Log directly it seems that it shouldn't return such a hard error (die) when Apache::ASP makes that call internally.

Set these things to help catch these problems:

  PerlSetVar UseStrict 1
  PerlWarn On

I can do the later... But not the first. While we run both on almost all our code bases, this particular code base is a legacy one (written by another company) with over 200k lines of client .pm and .asp files. (over 100k of custom perl modules alone). So, retroactively adapting all legacy code to use strict is infeasible.

And also always reference ASP object like this in XMLSubs:

  $main::Response

Alternatively, to make sure you do the former, put XMLSubs in
a package outside of global.asa

We use no XMLSubs. There is no XML support in our Apache::ASP install at all actually.

--
Theo Schlossnagle
Principal Consultant
OmniTI Computer Consulting, Inc. -- http://www.omniti.com/
Phone: +1 410 872 4910 x201 Fax: +1 410 872 4911
1024D/82844984/95FD 30F1 489E 4613 F22E 491A 7E88 364C 8284 4984
2047R/33131B65/71 F7 95 64 49 76 5D BA 3D 90 B9 9F BE 27 24 E7


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]