Hi Andy.
I was quite busy, but a few days ago I cloned the repo and successfully ran the build with "skip tests". I had to switch from JDK 11 to 8, though, because with Oracle JDK 11 there was some problem with generating Javadocs. I guess Maven did not find the generator. I have not looked into it, just wanted to make you aware of it.
Yesterday I ran a full build (mvn clean install) and had a test failure. I wanted to see if there were more failing tests on my Windows machine and just ran it again with -Dmaven.test.failure.ignore=true. The build completed after about 23 minutes on my machine and there were a couple more failures in one test class in addition to the failure I had seen before. I am attaching both Surefire logs here for you and just wanted to ask if these failures are currently to be expected due to some work in progress or platform-specific issue or if it is worth looking into that further.
Best regards
--
Alexander Kriegisch
--
Alexander Kriegisch
https://scrum-master.de
Andrew Clement schrieb am 13.02.2019 05:37:
One question, just in case: Would PRs against the GitHub repo be okay?Yes, I think so. But there are some shenanigans necessary to ensure the commit is signed off for easy acceptance, I discussed it in here with another guy who contributed that way - not even sure we got to a conclusion, but if they are signed off in an easy form for me to integrate, that’ll obviously reduce the time they take to process.AndyOn Feb 11, 2019, at 5:05 PM, Alexander Kriegisch <alexan...@kriegisch.name> wrote:Great news, Andy, thank you so much. This weekend or the next I guess I
will take a look.
One question, just in case: Would PRs against the GitHub repo be okay?
Regards
--
Alexander Kriegisch
https://scrum-master.de
Andrew Clement schrieb am 12.02.2019 06:29:
It is alive. AspectJ, well overdue, now has as rudimentary maven
build. It builds on the few systems I’ve tried it on although some
of the tests seem to be a bit flaky on windows (I’ve not run the
tests on windows for a long time so I don’t think it is due to the
maven process, it just never used to be this easy to run them on a
different OS). If anyone wants to help polish it, please do, I’m not
a maven guru. There are some of the jar dependencies that need
converting from local jar references to real dependencies from a
repository but I haven’t had a chance to work out the exact version
numbers. You can ‘mvn install’ and it will build
aspectjrt/aspectjweaver/aspectjtools and then you can consume them
from your local repo (although the poms need a bit of work). There is
an installer project that builds the installer distribution we also
make available. I’ve imported it into eclipse using m2e, I haven’t
tried it with IntelliJ - I’d be interested to know if that works.
If nothing else this may make it easier for folks to consume snapshot
builds that include workarounds or early fixes as they can more easily
build/install it locally now.
If anyone wants to try it out, please do, raise bugs, contribute fixes
:)
There are extra benefits I snuck in:
-- I deleted the projects ending in ‘5’ (created when Java5 was
separate to Java 1.4) and merged them into the non 5 variants.
-- bcel-builder is no longer a ’special project’ you had to
build separately. It is just a regular sub-module
-- If you do want to run the tests in eclipse, I added a few lines
explanation in the new README at
https://github.com/eclipse/org.aspectj
I guess the true test of this will be when I try to use it to release
1.9.3 but as it produces the same artifacts, I should be able to use
the same release process there.
_______________________________________________
aspectj-users mailing list
aspectj-users@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/aspectj-users
------------------------------------------------------------------------------- Test set: org.aspectj.internal.lang.reflect.AjTypeTest ------------------------------------------------------------------------------- Tests run: 44, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.14 sec
------------------------------------------------------------------------------- Test set: org.aspectj.tests.TestsModuleTests ------------------------------------------------------------------------------- Tests run: 2974, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 1,039.092 sec <<< FAILURE! testOptionalAspects_pr398588(org.aspectj.systemtest.ajc172.Ajc172Tests) Time elapsed: 2.621 sec <<< FAILURE! junit.framework.AssertionFailedError: expecting output: AspectJ Weaver Version register classloader using configuration register aspect AspectA deactivating aspect register aspect AspectB register aspect AspectC register aspect AspectD deactivating aspect 'AspectD' as it requires type 'a.b.c.Anno2' which cannot be found on the classpath Join point 'method-execution(void Code.main(java.lang.String[]))' in Type 'Code' (Code.java:7) advised by before advice from 'AspectC' Join point 'staticinitialization(void Code.<clinit>())' in Type 'Code' (Code.java) advised by before advice from 'AspectB' processing reweavable processing reweavable but found output: [WeavingURLClassLoader] info AspectJ Weaver Version 1.9.3.BUILD-SNAPSHOT built on Sonntag Feb 24, 2019 at 17:23:19 PST [WeavingURLClassLoader] info register classloader org.aspectj.weaver.loadtime.WeavingURLClassLoader [WeavingURLClassLoader] info using configuration /C:/temp/ajcSandbox/AspectJ/ajcTest4072402535445848038.tmp/META-INF/aop.xml [WeavingURLClassLoader] info register aspect AspectA [WeavingURLClassLoader] info register aspect AspectB [WeavingURLClassLoader] info register aspect AspectC [WeavingURLClassLoader] info register aspect AspectD [WeavingURLClassLoader] weaveinfo Join point 'method-execution(void Code.main(java.lang.String[]))' in Type 'Code' (Code.java:7) advised by before advice from 'AspectC' (AspectC.java:4) [WeavingURLClassLoader] weaveinfo Join point 'staticinitialization(void Code.<clinit>())' in Type 'Code' (Code.java) advised by before advice from 'AspectB' (AspectB.java:2) [WeavingURLClassLoader] info processing reweavable type AspectB: \AspectB.java [WeavingURLClassLoader] info processing reweavable type AspectC: \AspectC.java Expected 13 lines of output but there are 11
at junit.framework.Assert.fail(Assert.java:47) at org.aspectj.testing.OutputSpec.createFailureMessage(OutputSpec.java:122) at org.aspectj.testing.OutputSpec.matchAgainst(OutputSpec.java:76) at org.aspectj.testing.RunSpec.execute(RunSpec.java:69) at org.aspectj.testing.AjcTest.runTest(AjcTest.java:68) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:156) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:170) at org.aspectj.systemtest.ajc172.Ajc172Tests.testOptionalAspects_pr398588(Ajc172Tests.java:162) testOptionalAspects_pr310506(org.aspectj.systemtest.ajc169.Ajc169Tests) Time elapsed: 2.535 sec <<< FAILURE! junit.framework.AssertionFailedError: expecting output: AspectJ Weaver Version register classloader using configuration register aspect deactivating aspect register aspect processing reweavable but found output: [WeavingURLClassLoader] info AspectJ Weaver Version 1.9.3.BUILD-SNAPSHOT built on Sonntag Feb 24, 2019 at 17:23:19 PST [WeavingURLClassLoader] info register classloader org.aspectj.weaver.loadtime.WeavingURLClassLoader [WeavingURLClassLoader] info using configuration /C:/temp/ajcSandbox/AspectJ/ajcTest5008270407106872549.tmp/META-INF/aop.xml [WeavingURLClassLoader] info register aspect AspectA [WeavingURLClassLoader] info register aspect AspectB [WeavingURLClassLoader] info processing reweavable type AspectB: \AspectB.java Expected 7 lines of output but there are 6 at junit.framework.Assert.fail(Assert.java:47) at org.aspectj.testing.OutputSpec.createFailureMessage(OutputSpec.java:122) at org.aspectj.testing.OutputSpec.matchAgainst(OutputSpec.java:76) at org.aspectj.testing.RunSpec.execute(RunSpec.java:69) at org.aspectj.testing.AjcTest.runTest(AjcTest.java:68) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:156) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:170) at org.aspectj.systemtest.ajc169.Ajc169Tests.testOptionalAspects_pr310506(Ajc169Tests.java:54) testAnnotationProcessing1(org.aspectj.systemtest.incremental.tools.AnnotationProcessingTests) Time elapsed: 2.229 sec <<< FAILURE! junit.framework.AssertionFailedError: These were not expected to be compiled: [C:\Users\alexa\Documents\java-src\AspectJ\tests\Advise_aaa.java, C:\Users\alexa\Documents\java-src\AspectJ\tests\Advise_ccc.java, C:\temp\ajcSandbox\AspectJ\ajcTest5158176265904362313.tmp\ProcessorConsumer1\src\Code.java] at junit.framework.Assert.fail(Assert.java:47) at org.aspectj.systemtest.incremental.tools.AnnotationProcessingTests.checkCompiledFiles(AnnotationProcessingTests.java:164) at org.aspectj.systemtest.incremental.tools.AnnotationProcessingTests.testAnnotationProcessing1(AnnotationProcessingTests.java:56) testAnnotationProcessing3(org.aspectj.systemtest.incremental.tools.AnnotationProcessingTests) Time elapsed: 3.29 sec <<< FAILURE! junit.framework.AssertionFailedError: These were not expected to be compiled: [C:\Users\alexa\Documents\java-src\AspectJ\tests\AroundAdvise_ccc.java, C:\Users\alexa\Documents\java-src\AspectJ\tests\AroundAdvise_aaa.java, C:\Users\alexa\Documents\java-src\AspectJ\tests\Advise_ccc.java, C:\Users\alexa\Documents\java-src\AspectJ\tests\Advise_aaa.java, C:\temp\ajcSandbox\AspectJ\ajcTest1249005617348019978.tmp\ProcessorConsumer1\src\Code.java] at junit.framework.Assert.fail(Assert.java:47) at org.aspectj.systemtest.incremental.tools.AnnotationProcessingTests.checkCompiledFiles(AnnotationProcessingTests.java:164) at org.aspectj.systemtest.incremental.tools.AnnotationProcessingTests.testAnnotationProcessing3(AnnotationProcessingTests.java:122) testAnnotationProcessing2(org.aspectj.systemtest.incremental.tools.AnnotationProcessingTests) Time elapsed: 2.214 sec <<< FAILURE! junit.framework.AssertionFailedError: These were not expected to be compiled: [C:\Users\alexa\Documents\java-src\AspectJ\tests\Advise_ccc.java, C:\Users\alexa\Documents\java-src\AspectJ\tests\Advise_aaa.java, C:\temp\ajcSandbox\AspectJ\ajcTest8312109468321996609.tmp\ProcessorConsumer2\src\Code.java] at junit.framework.Assert.fail(Assert.java:47) at org.aspectj.systemtest.incremental.tools.AnnotationProcessingTests.checkCompiledFiles(AnnotationProcessingTests.java:164) at org.aspectj.systemtest.incremental.tools.AnnotationProcessingTests.testAnnotationProcessing2(AnnotationProcessingTests.java:84) testServerWithHelloWorld(org.aspectj.systemtest.ajc150.ltw.LTWServerTests) Time elapsed: 1.545 sec <<< FAILURE! junit.framework.AssertionFailedError: expecting output: Starting ... Running HelloWorld Hello World! Stopping ... but found output: Starting ... Unable to locate 'org.aspectj' in C:\Users\alexa\Documents\java-src\AspectJ\tests\ltw Expected 4 lines of output but there are 2 at junit.framework.Assert.fail(Assert.java:47) at org.aspectj.testing.OutputSpec.createFailureMessage(OutputSpec.java:122) at org.aspectj.testing.OutputSpec.matchAgainst(OutputSpec.java:76) at org.aspectj.testing.OutputSpec.matchAgainst(OutputSpec.java:52) at org.aspectj.testing.AntSpec.execute(AntSpec.java:206) at org.aspectj.testing.AjcTest.runTest(AjcTest.java:68) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:156) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:170) at org.aspectj.systemtest.ajc150.ltw.LTWServerTests.testServerWithHelloWorld(LTWServerTests.java:20) testServerWithParentAndChild(org.aspectj.systemtest.ajc150.ltw.LTWServerTests) Time elapsed: 0.908 sec <<< FAILURE! junit.framework.AssertionFailedError: expecting output: Starting ... Running HelloWorld Hello World! Stopping ... but found output: Starting ... Unable to locate 'org.aspectj' in C:\Users\alexa\Documents\java-src\AspectJ\tests\ltw Expected 4 lines of output but there are 2 at junit.framework.Assert.fail(Assert.java:47) at org.aspectj.testing.OutputSpec.createFailureMessage(OutputSpec.java:122) at org.aspectj.testing.OutputSpec.matchAgainst(OutputSpec.java:76) at org.aspectj.testing.OutputSpec.matchAgainst(OutputSpec.java:52) at org.aspectj.testing.AntSpec.execute(AntSpec.java:206) at org.aspectj.testing.AjcTest.runTest(AjcTest.java:68) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:156) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:170) at org.aspectj.systemtest.ajc150.ltw.LTWServerTests.testServerWithParentAndChild(LTWServerTests.java:24) testHandleDuplicateConfiguration_pr157474(org.aspectj.systemtest.ajc153.LTWServer153Tests) Time elapsed: 1.411 sec <<< FAILURE! junit.framework.AssertionFailedError: expecting output: Starting ... Running HelloWorld ? main Hello World! Stopping ... but found output: Starting ... Unable to locate 'org.aspectj' in C:\Users\alexa\Documents\java-src\AspectJ\tests\bugs153\pr157474 Expected 5 lines of output but there are 2 at junit.framework.Assert.fail(Assert.java:47) at org.aspectj.testing.OutputSpec.createFailureMessage(OutputSpec.java:122) at org.aspectj.testing.OutputSpec.matchAgainst(OutputSpec.java:76) at org.aspectj.testing.OutputSpec.matchAgainst(OutputSpec.java:52) at org.aspectj.testing.AntSpec.execute(AntSpec.java:206) at org.aspectj.testing.AjcTest.runTest(AjcTest.java:68) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:156) at org.aspectj.testing.XMLBasedAjcTestCase.runTest(XMLBasedAjcTestCase.java:170) at org.aspectj.systemtest.ajc153.LTWServer153Tests.testHandleDuplicateConfiguration_pr157474(LTWServer153Tests.java:21) testIncrementalBuildAdviceChange_456801(org.aspectj.systemtest.incremental.tools.MultiProjectIncrementalTests) Time elapsed: 1.121 sec <<< FAILURE! junit.framework.ComparisonFailure: expected:<... run() running...> but was:<... run() running ...> at junit.framework.Assert.assertEquals(Assert.java:81) at junit.framework.Assert.assertEquals(Assert.java:87) at org.aspectj.systemtest.incremental.tools.MultiProjectIncrementalTests.testIncrementalBuildAdviceChange_456801(MultiProjectIncrementalTests.java:3582)
_______________________________________________ aspectj-users mailing list aspectj-users@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/aspectj-users
