(De-cloaking after years of silence) It's somewhere between lazy and truly evil. Lazy because you could just use a label. Why are people so allergic to using labels ffs? Evil because it isn't always obvious where you're intending to branch. Perhaps you calculated the offset wrong. Perhaps someone came along later and added one or more instructions between your carefully crafted branch instruction and its target ... there are many ways to fail and almost no plausible benefits. Do everyone a favor. Use labels. > I was raised to do single-instruction branches thus: > TM FLAG,BIT Is the flag bit set? > BO *+8 Yes, skip next instruction > L R15,SOMEVAL No, get the value > *+8 DS 0H > > Yes, of course I realize that the "DS 0H" is meaningless, but it helps > readability. > > My question is whether folks see this as: > - useful > - common > - overly clever > - evil > ...or what? > > I've often wished for an assembly option that would note "*+n" branches and > warn if they were not skipping one instruction (and doing so *exactly*!).
