Hi Roger,

>From looking at what wasn't freed, I'm guessing that you had a failure
in the pcap compile, etc. 

The error exits in that code didn't free things up properly.

==28727== 110 bytes in 1 blocks are definitely lost in loss record 35 of 59
==28727==    at 0x4C2B3F8: malloc (in 
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==28727==    by 0x4E3ED16: create_pcap_listener (pcap_min.c:104)
==28727==    by 0x4E3F683: g_source_pcap_new (pcap_GSource.c:124)
==28727==    by 0x4E42EE8: switchdiscovery_new (switchdiscovery.c:133)
==28727==    by 0x4E4C652: nano_start_full (nanoprobe.c:986)

Here's the malloc code (at line 104 above):
        if (NULL == (*expr* = malloc(filterlen))) {
                g_error("Out of memory!");
                return NULL;
        }

Since the non-failure case looks like this:
        DEBUGMSG1("Compile of [%s] worked!\n", expr);
        free(*expr*); expr = *NULL*;
        return(pcdescr);

then it's reasonable to assume that your invocation didn't go through that 
return case.

So I put this error exit code in:

oopsie: // Some kind of failure - free things up and return NULL

        if (expr) {
                free(expr);
                expr = NULL;
        }
        if (pcdescr) {
                close_pcap_listener(pcdescr, dev, listenmask);
                pcdescr = NULL;
        }
        return NULL;

Along with ensuring that expr and pcdescr initialized to NULL.


There may also be other issues.  But that one seems clear...



On 03/18/2013 08:40 AM, Roger wrote:
> I hg cloned the repo today (03/18).
>
> hg clone 'http://hg.linux-ha.org/%7Cexperimental/assimilation/'
>
> cmake went fine as did testify tests.
>
> The grind.sh test resulted in the attached output - a bit long to put
> inline.
>
> Roger
>
>
> _______________________________________________
> Assimilation mailing list - Discovery-Driven Monitoring
> [email protected]
> http://lists.community.tummy.com/cgi-bin/mailman/listinfo/assimilation
> http://assimmon.org/


-- 
    Alan Robertson <[email protected]> - @OSSAlanR

"Openness is the foundation and preservative of friendship...  Let me claim 
from you at all times your undisguised opinions." - William Wilberforce

_______________________________________________
Assimilation mailing list - Discovery-Driven Monitoring
[email protected]
http://lists.community.tummy.com/cgi-bin/mailman/listinfo/assimilation
http://assimmon.org/

Reply via email to