Fritz-
you sure do work quickly...  I see my code (adapted by you) for the bayesian
test user in 1.4.1.1.25 already!  Wonderful to see it.

Good catch on mlog to passtext change.  However, I minor additional fix:

You might want to change
     $passtext = "passing as safe because testmode, otherwise blocked
($reason)";
to:
    $passtext = "passing because $this->{testmode}, otherwise blocked
($reason)";
 to be more like it was in 1.4.1.1.21.  This will let the exact type of
testmode be known.

While we're at it, I looked at this a bit more, and the whole thing can be
streamlined.

based on 1.4.1.1.25
remove my $BaysTestUser=0;      and   $BaysTestUser=1;
from
   my $BaysTestUser=0;
 if ($reason =~ /Bayesian/) {
  if (allSH( $this->{rcpt}, 'baysTestModeUserAddresses' )) {
  $this->{testmode} = "bays test mode user";
  $BaysTestUser=1;
  $slok=0; # make sure it's not flagged as a spam lover
  }
 }

yeilding:
 if ($reason =~ /Bayesian/) {
  if (allSH( $this->{rcpt}, 'baysTestModeUserAddresses' )) {
  $this->{testmode} = "bays test mode user";
  $slok=0; # make sure it's not flagged as a spam lover
  }
 }


Change
  } elsif ( $testmode ) {
     if ($BaysTestUser) {
     $this->{prepend}.="[bays test user]";
     $this->{saveprepend2}.="[bays test user]";
     $passtext = "passing as safe because bays test user, otherwise blocked
($reason)";
     } else {
     # regular test mode
     $this->{prepend}.="[testmode]";
     $this->{saveprepend2}.="[testmode]";
     $passtext = "passing as safe because testmode, otherwise blocked
($reason)";
     }
back to the way it was in 1.4.1.1.21, including $this->{testmode} describing
the mode
  } elsif ( $testmode ) {
     $this->{prepend}.="[testmode]";
     $this->{saveprepend2}.="[testmode]";
     $passtext = "passing because $this->{testmode}, otherwise blocked
($reason)";

This will not put [bays test user] as a prepend, but who cares, it'll still
be in the passtext...  A little less processing x thousands of messages =
good.

Thanks again for working so hard for all of us!
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Assp-test mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/assp-test

Reply via email to