On Sun, 15 Mar 2009 03:46:00 +0100, "Fritz Borgstedt" <[email protected]> wrote:
>
>
> >
> > sendque($fh, "EHLO $Con{$cli}->{helo}\r\n");
> > change to
> > sendque($fh, "EHLO $myName\r\n");
>
> Did you test it ?
>
On second thoughts, Fritz, I don't think this patch is good.
Firstly: if $myName is left at the default value: "ASSP.nospam",
this will not work. For the above to work, $myName must be changed
to a valid DNS hostname. Better would be to use $localhostname which
ASSP sets to its own hostname.
Secondly: the above code only appears in RMhelo, CChelo and FShelo.
These subs are used when ASSP is re-originating a message. When
an incoming message is received, the client's HELO/EHLO is passed
in getline so it is the helo|ehlo code there that will need changing
(as well as the three XXhelo subs).
Thirdly: a possible consequence... While a change such as this is
arguably correct RFC behavior, it will result in the MTA seeing a
dialog with a HELO/EHLO containing it's own (or another local
hostname) followed by a MAIL From with a sender from anywhere in
the world. If the MTA is also doing its own checks, in particular
an SPF lookup, the MTA will then reject the message. In theory a
possible problem. In practice, this may not actually be an issue
if MTAs don't care. But, perhaps worth making a config switch for
this?
Fourthly: the change also needs to be made in sub reply where
the MTA side might be switched to SSL. In that case, ASSP resends
the EHLO.
This is, in principle, a good idea but the patch is more complex
than the one above. I might have another look tomorrow - it's late
here now.
-jr
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Assp-test mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/assp-test
