You are right - this has to be corrected. if inside a report request a recipient is defines which is not an admin - the link will be not added -> 5.12.
Thomas K Post <[email protected]> 01.11.2009 18:15 Bitte antworten an ASSP development mailing list <[email protected]> An ASSP development mailing list <[email protected]> Kopie Thema Re: [Assp-test] added to 2.0.1_RC0.5.11 The part that I was hung up on was determining when it was an admin user that was GETTING the report, not requesting it. You seem to determine whether the link will appear based on the mail from address, not the recipient address. if ( matchSL( $this->{mailfrom}, 'EmailAdmins', 1 ) or lc( $this->{mailfrom} ) eq lc($EmailAdminReportsTo) or lc( $this->{mailfrom} ) eq lc($EmailBlockTo) ) { $isadmin = 1; If I'm understanding correctly, this means that if I as an admin email a request for a report to a regular user, they'll get the links right? Definitely don't want that. Also, there's the BlockReportFile option. We have block reports go to each deparatement head on a nightly (doing a wildcard for their subdomains do they can see blocked emails for anyone in their department). They're NOT admins though. I'm not sure if this would show the links for them or not. I think what we need to do is put the filename in each body line and then when the SendBlockReport sub runs, we check the TO here. If that to is an admin then to a regex to replace the filename in the body variable with a link and if it's not an admin, just remove the filename. That might not be the best solution, but I'm pretty sure that we at least need to be checking the recipient in that sub, instead of checking the requestor. On Sun, Nov 1, 2009 at 12:00 PM, K Post <[email protected]> wrote: > many thanks! You're (obviously) much better at this than I am. i'm > still hacking through the code. > > When you have a moment, can you readdress the issues I'm seeing with > nogreedywhitelist? > Thanks > > On Sun, Nov 1, 2009 at 11:42 AM, Thomas Eckardt/eck > <[email protected]> wrote: >> the following is added to 2.0.1_RC0.5.11 >> >> >> - ['BlockReportHTTPName','My HTTP Name','The hostname for HTTP(S) links in >> AdminUsers Blockreports. If not defined the local hostname will be used.', >> >> The date in every HTTP-AdminUsers-Blockreport line contains a http link to >> open the .eml file like in MaillogTail, if the file exists. >> >> Thomas >> >> >> DISCLAIMER: >> ******************************************************* >> This email and any files transmitted with it may be confidential, legally >> privileged and protected in law and are intended solely for the use of the >> >> individual to whom it is addressed. >> This email was multiple times scanned for viruses. There should be no >> known virus in this email! >> ******************************************************* >> >> >> ------------------------------------------------------------------------------ >> Come build with us! The BlackBerry(R) Developer Conference in SF, CA >> is the only developer event you need to attend this year. Jumpstart your >> developing skills, take BlackBerry mobile applications to market and stay >> ahead of the curve. Join us from November 9 - 12, 2009. Register now! >> http://p.sf.net/sfu/devconference >> _______________________________________________ >> Assp-test mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/assp-test >> > ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Assp-test mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/assp-test DISCLAIMER: ******************************************************* This email and any files transmitted with it may be confidential, legally privileged and protected in law and are intended solely for the use of the individual to whom it is addressed. This email was multiple times scanned for viruses. There should be no known virus in this email! ******************************************************* ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Assp-test mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/assp-test
