Zrin,

>I mean subjects of the blocked e-mails, in each entry in the report, 
like with
> $line =~ s/\[([^\]]+)\] ;/<br\/>[<strong>$1<\/strong>]/;


Next version will do something similar.



>>> 1) The markup für the icon in the html part of the block report
> sometimes gets splitted within the cid: number, like

Next version will wrap the HTML code in lines with max 76 characters.

Thomas



Von:    Zrin Ziborski <[email protected]>
An:     ASSP development mailing list <[email protected]>
Datum:  18.08.2010 12:55
Betreff:        Re: [Assp-test] Further problems with Block-reports




Am 18.08.2010 09:33, schrieb Thomas Eckardt:
>> Error: syntax error in report address in
>> /usr/share/assp/files/blockreportuser.txt in entry
>> *...@non_local_domain=>[email protected]=>2
>> According to help text that should be a valid entry (?)
 >
> ??  - replace  'non_local_domain' with the ('non local') domain name you
> want to search for.
>
I see... I wanted to see what a report for all non-local domains would 
look like
(since *...@*=>... is for all local domains)

>> I'd suggest to make subject bold ("strong")
> Edit the 'blockreport_sub.txt' to do this.
>
I mean subjects of the blocked e-mails, in each entry in the report, 
like with
> $line =~ s/\[([^\]]+)\] ;/<br\/>[<strong>$1<\/strong>]/;
> to getBlockReasons just before "$line = Encode::encode("utf-8", $line)
> ...", but I guess there's a cleaner solution.


>> 1) The markup für the icon in the html part of the block report
> sometimes gets splitted within the cid: number, like
>
> ASSP is not doing this nor should this be done by the HTML-Browser. It
> could be happen that a source viewer shows the HTML source this way, but
> this could be ignored.

Probably the e-mail client or MTA are doing that, somwhere
there is a line lenght limit (it is not the viewer - for sure).
Note that the whole html part of a block report was in one line.
The splitted markup does break the html structure - it
is mostly visible as missing icon or distorted table structure,
sometimes as a broken link.

Inserting a newline "now and then" prevents building overlong lines
and thus prevents this problem, like with

$line =~
s/(.*)/\n<tr bgcolor="$bgcolor"><td WIDTH="20px" valign="MIDDLE" 
align="center" style="border-bottom: 1px solid 
#C0C0C0">\n$leftbut<\/td><td WIDTH="94%" style="border-bottom: 1px solid 
#C0C0C0;"><br \/>$1<br \/><\/td><td align="center" valign="MIDDLE" 
WIDTH="3%" style="border-bottom: 1px solid 
#C0C0C0;">\n$rightbut<\/td><\/tr>/;

in sub getBlockReasons (added \n at the start of replacement part).
I've also added \n in front of every icon link to be sure.
With that change long reports are not distorted any more.

best regards,
Zrin


------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Assp-test mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/assp-test



DISCLAIMER:
*******************************************************
This email and any files transmitted with it may be confidential, legally 
privileged and protected in law and are intended solely for the use of the 

individual to whom it is addressed.
This email was multiple times scanned for viruses. There should be no 
known virus in this email!
*******************************************************


------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Assp-test mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/assp-test

Reply via email to