Thomas, I have also sent you a version 14141 to your email with the bugs I
mentioned before fixed as well as the changes below...


BATV issues...

There are lots of regexes in the code using prvs=\d\d\d\d\w{6}=

I get lots or email where there are NOT 4 digits at the start NOR a six
character word after, eg...
<prvs=209cc689b=dsitt...@sick.com.au> 
<prvs=2110e75cb=tony.sculp...@nord.com>

This results in them not being treated as whitelisted.

There are also 2??? Subs named batv_remove_tag in the code, 1 tight
(prvs=\d\d\d\d\w{6}=) , and one very loose later (prvs=.*=).

sub batv_remove_tag {
    my ($fh,$mailfrom,$store) = @_;
    if ($mailfrom =~ /^(prvs=\d\d\d\d\w{6}=)([^\r\n]*)/o) {
        $Con{$fh}->{$store} = $mailfrom if ($fh && $store);
        $mailfrom = lc $2;
    }
    return $mailfrom;
}

sub batv_remove_tag {
    my $mailfrom = shift;
    if ($mailfrom =~ /^( prvs=.*=)(.*)/o) {   #Batv Mod - JC (prvs=\w=) or
prvs=.*=
        $mailfrom = lc $2;
    }
    return $mailfrom;
}


They should all be looser but not too loose, say prvs=\w=

John Calvi.



------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Assp-user mailing list
Assp-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/assp-user

Reply via email to