On Sat, 20 Apr 2013 02:46:33 +0200 Roland Mainz wrote: > On Thu, Apr 18, 2013 at 4:26 PM, Glenn Fowler <[email protected]> wrote: > > On Tue, 16 Apr 2013 23:03:41 +0200 Roland Mainz wrote: > >> On Wed, Apr 10, 2013 at 1:57 PM, Roland Mainz <[email protected]> > >> wrote: > >> > On Wed, Apr 10, 2013 at 1:32 PM, Roland Mainz <[email protected]> > >> > wrote: > >> >> [CC:'ing Werner since this is i18n related and was only observed on > >> >> SuSE 12.3 Linux for now...] > >> >> > >> >> Attached (as "astksh20130409_suse123_32bit_builtin_iconv_hang1.txt.gz") > >> >> is a (compressed) text file which causes the AST "iconv" builtin > >> >> utility from ast-ksh.2013-04-09 to "hang" in an endless loop in 32bit > >> >> i386 builds (AMD64 64bit builds are OK... *ONLY* the 32bit builds loop > >> >> forever...). > >> >> > >> >> Example: > >> >> -- snip -- > >> >> $ gunzip astksh20130409_suse123_32bit_builtin_iconv_hang1.txt.gz > >> >> $ LC_ALL=en_US.UTF-8 ../build_i386_32bit_debug/arch/linux.i386/bin/ksh > >> >> -c 'builtin iconv ; iconv -f UTF-8 > >> >> /tmp/astksh20130409_suse123_32bit_builtin_iconv_hang1.txt >/tmp/zzz2 ; > >> >> true' > >> >> <hangs forever> > >> >> -- snip -- > > > > roland, try replacing _ast_iconv_move() in src/lib/libast/comp/iconv.c with > > the attached code -- the old code had trouble all over the place
> Thanks... :-) > ... so far I didn't hit any endless loops or other problems with the > patch... but testing is still in progress here... > > the new code should handle all mmap() boundaries > > I'll test it against truly invalid byte sequences on mmap boundaries later > > today > Ok... > ... did you find any issues on your side yet ? did not test invalid bytes sequences yet _______________________________________________ ast-developers mailing list [email protected] http://lists.research.att.com/mailman/listinfo/ast-developers
