On Fri, Aug 9, 2013 at 9:07 PM, Irek Szczesniak <[email protected]> wrote:
> Fedora 19 is *again* missing the #define O_SEARCH to define O_SEARCH
> as alias to O_PATH.

This broke a while ago when #define __USE_GNU 1 was moved to
src/lib/libast/features/standards. Nice attempt but won't work because
__USE_GNU is an internal flag of the Linux kernel headers and is unset
by the normal includes in /usr/include. Worst of all the Linux
includes are broken and only reveal O_PATH if used with __USE_GNU=1.

What I don't understand: Roland added a safeguard against malfunctions:
/*
 * Make sure _GNU_SOURCE is active on Linux. Some versions
 * give us serious trouble in this case so we have this
 * assert to *abort* early instead of let us hunt for "ghost
 * bugs"
 */
#ifdef __linux__
#ifndef __USE_GNU
#error "ASSERT: __USE_GNU should be defined by now"
#endif
#endif

This had been introduced to *prevent* this from happening. WTF was
this assertion removed? This is really the kind of regression which
should NEVER happen because it fucks up the rest of the applications.

Wasted time: 2h 17 minutes to find out that O_SEARCH was unavailable
in our application. Anyone wanna pay?

Irek
_______________________________________________
ast-developers mailing list
[email protected]
http://lists.research.att.com/mailman/listinfo/ast-developers

Reply via email to