On 19 August 2013 11:29, Roland Mainz <[email protected]> wrote: > On Mon, Aug 19, 2013 at 9:25 AM, Irek Szczesniak <[email protected]> > wrote: >> On Mon, Aug 19, 2013 at 1:07 AM, Roland Mainz <[email protected]> >> wrote: >>> Attached (as "astksh20130814_sigqueuerepeat001.diff.txt") is a patch >>> which fixes a couple of problems with kill(1)'s |sigqueue()| support. > [snip] >> Nit: Is there *ever* a reason to use --norepeat? > > Yes... if the script wishes to do it's own handling of |EAGAIN| for > some reason... > > [snip] >> The patch looks good in general except these nits: >> - kill --help misses some spaces > > Fixed. > >> - A NOTES section explaining that the number of realtime signals is >> flexible might be good > > I'll defer that to a late patch. The primary issue is that $ getconf > RTSIG_MAX # returns the number of signals supported by the kernel... > but glibc and stuff like valgrind may dynamically use one or more > realtime signals for their own usage... reducing the number of > available realtime signals reported by $ kill -l # ... it may require > some thinking before writing such a NOTES section... > >> - I dislike the abuse of Shell_t as dumping ground for everything. >> This includes sigval_t. Could you find a better way, e.g. pass it as >> parameter? > > I agree... but the issue is that I need to update the coshell support > and I'm not sure about the consequences yet. I have to ask Glenn for > suggestions/help... > >> - IMO Shell_t needs to be cleaned up a lot. Its an unstructured, >> unclean mess, IMO only second to the jobs variable in terms of being a >> source of possible bugs and confusion. > > Grumpf... I partially agree... I wish |Shell_t| would be more > structured, e.g. that the consumers (lexer/parser) all have their > struct ShLex/ShParser/etc. to store their variables there so it > becomes easier to figure out which subsystem in ksh93 uses which > variable... it would also help instrumentation utilities to keep track > of uninitalised variables etc. > > Attached (as "astksh20130814_sigqueuerepeat002.diff.txt") is a patch > which fixes (some of) the issues listed above...
Roland, thank you. The patch cures the signal problems we found. kill -q now works even with massive signal storms on 64 core machines, which didn't do it previously (at least not in a reliable way). Now, what's the status of the patch? is it going to be part of the next alpha? Ced -- Cedric Blancher <[email protected]> Institute Pasteur _______________________________________________ ast-developers mailing list [email protected] http://lists.research.att.com/mailman/listinfo/ast-developers
