On Mon, Dec 9, 2013 at 5:21 PM, Roland Mainz <roland.ma...@nrubsig.org>wrote:
> On Mon, Dec 9, 2013 at 11:08 PM, Glenn Fowler <glenn.s.fow...@gmail.com> > wrote: > > On Mon, Dec 9, 2013 at 4:53 PM, Roland Mainz <roland.ma...@nrubsig.org> > > wrote: > [snip] > >> 4. The patch removes one unneccesary |memset(p, 0, size)| which was > >> touching pages and therefore allocating them > > > > if that memset(0) is in vmopen() then im not sure its unnecessary > > > > run these tests to check your patch with different sizes and with/without > > the memset(0) > > > > bin/package use > > cd builtin > > nmake test > > Seems to be no problem... and neither valgrind nor Rational Purify > complained. I think the issue is that a memory page obtained via > |mmap(MAP_ANON)| is zero'ed by the system on the first > read/write/execute access. > it consistently chokes for getmem=safe memset(0) is required but only the head part to cover the 2 small vmalloc structs
_______________________________________________ ast-developers mailing list ast-developers@lists.research.att.com http://lists.research.att.com/mailman/listinfo/ast-developers
