ksh 2014-01-14 fails to compile on OS X 10.7.5 (Xcode 4.6.1) due to the
following error:

========================================
/tmp/ast-ksh.2014-01-14/src/lib/libcmd/ls.c:1260:3: error: non-void
function 'ls' should return a value [-Wreturn-type]
                return;
                ^
/tmp/ast-ksh.2014-01-14/src/lib/libcmd/ls.c:1268:3: error: non-void
function 'ls' should return a value [-Wreturn-type]
                return;
                ^
/tmp/ast-ksh.2014-01-14/src/lib/libcmd/ls.c:1273:3: error: non-void
function 'ls' should return a value [-Wreturn-type]
                return;
                ^
========================================

The fix is straightforward:

========================================
--- ./src/lib/libcmd/ls.c.orig  2013-12-08 01:24:57.000000000 -0600
+++ ./src/lib/libcmd/ls.c       2014-02-04 08:34:10.000000000 -0600
@@ -1257,7 +1257,7 @@
        if (!VISIBLE(state, ent))
        {
                fts_set(NiL, ent, FTS_SKIP);
-               return;
+               return 0;
        }
        switch (ent->fts_info)
        {
@@ -1265,12 +1265,12 @@
                if (ent->fts_parent->fts_info == FTS_DNX)
                        break;
                error(2, "%s: not found", ent->fts_path);
-               return;
+               return 0;
        case FTS_DC:
                if (state->lsflags & LS_DIRECTORY)
                        break;
                error(2, "%s: directory causes cycle", ent->fts_path);
-               return;
+               return 0;
        case FTS_DNR:
                if (state->lsflags & LS_DIRECTORY)
                        break;
========================================

--
Nathan Weeks
IT Specialist
USDA-ARS Corn Insects and Crop Genetics Research Unit
http://weeks.public.iastate.edu/
_______________________________________________
ast-developers mailing list
ast-developers@lists.research.att.com
http://lists.research.att.com/mailman/listinfo/ast-developers

Reply via email to