Hi!

----

AFAIK the following part of "array.sh" has a small bug:
-- snip --
        compound hugecpv2=hugecpv
        [[ $(typeset -p hugecpv) == "$(typeset -p hugecpv)" ]]
EOF
) 2> /dev/null || err_exit 'copying a large array fails'
-- snip --

AFAIK you wanted to compare "hugecpv" with "hugecpv2" and not
"hugecpv" with itself, right ?
-- snip --
[[ $(typeset -p hugecpv) == "$(typeset -p hugecpv2)" ]]
-- snip --

BTW: This test runs a _very_ long time (~~one hour on my UltraSPARC-3i
machine) when vmalloc corruption tests are enabled. is it possible to
run it as "VMALLOC_OPTIONS='' $SHELL ..." to cut-down the time spend
in this test, please ?

Below is the diff for this change:
-- snip --
diff --git a/src/cmd/ksh93/tests/arrays.sh b/src/cmd/ksh93/tests/arrays.sh
index 63d5e97..4a3eedb 100755
--- a/src/cmd/ksh93/tests/arrays.sh
+++ b/src/cmd/ksh93/tests/arrays.sh
@@ -613,7 +613,8 @@ x=$(
 #test for cloning a very large index array - can core dump
 (
     trap 'x=$?;exit $(( $x!=0 ))' EXIT
-    $SHELL <<- \EOF
+    # VMALLOC_OPTIONS is cleared to cut-down the execution time of this test
+    VMALLOC_OPTIONS='' $SHELL <<- \EOF
        (
                print '('
                integer i
@@ -628,7 +629,7 @@ x=$(
                print ')'
        ) | read -C hugecpv
        compound hugecpv2=hugecpv
-       [[ $(typeset -p hugecpv) == "$(typeset -p hugecpv)" ]]
+       [[ "$(typeset -p hugecpv)" == "$(typeset -p hugecpv2 | sed
's/hugecpv2/hugecpv/g')" ]]
 EOF
 ) 2> /dev/null || err_exit 'copying a large array fails'

-- snip --

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) [email protected]
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 3992797
 (;O/ \/ \O;)

_______________________________________________
ast-developers mailing list
[email protected]
https://mailman.research.att.com/mailman/listinfo/ast-developers

Reply via email to