On Fri, Jun 8, 2012 at 2:10 PM, Irek Szczesniak <[email protected]> wrote: > On Thu, Jun 7, 2012 at 8:54 AM, Roland Mainz <[email protected]> wrote: >> On Wed, Jun 6, 2012 at 7:35 PM, Glenn Fowler <[email protected]> wrote: >>> >>> On Wed, 6 Jun 2012 19:31:57 +0200 Cedric Blancher wrote: >>>> Now that the patches for correct job control are being passed around, >>>> what do you *think* - are the grep and xargs builtins ready for >>>> inclusion into libcmd? >>> >>> this is basically the second round of builtin tests >>> my guess is we haven't hit all the the dark corners yet >>> we need a few rounds of no problems before moving them >> >> Mhhh... we've done some extensive testing with grep.c, xargs.c, tr.c >> and od.c in libcmd (basically using this hackery: >> -- snip -- >> function print_patch_extrabuiltins >> { >> # Make sure to use \\ instead of \ for continuations >> cat <<ENDOFPATCH >> --- src/lib/libcmd/Makefile 2012-01-10 19:48:50.000000000 +0100 >> +++ src/lib/libcmd/Makefile 2012-06-03 09:28:04.757483905 +0200 >> @@ -25,6 +25,7 @@ >> mkfifo.c mktemp.c mv.c paste.c pathchk.c pids.c rev.c rm.c \\ >> rmdir.c stty.c sum.c sync.c tail.c tee.c tty.c uname.c uniq.c \\ >> vmstate.c wc.c revlib.c wclib.c sumlib.o \\ >> + grep.c xargs.c tr.c od.c \\ >> fts_fix.c lib.c \\ >> -lfsg -lmd >> >> >> ENDOFPATCH >> } >> [snip] >> cp 'src/lib/libcmd/Makefile' 'src/lib/libcmd/Makefile.backup' >> # note this needs GNU patch which is available as >> # /usr/gnu/bin on Solaris 11 >> print_patch_extrabuiltins | \ >> ( \ >> export PATH='/usr/gnu/bin:/usr/bin' >> patch -p0 \ >> ) || fatal_error 'Patching failed.' >> cp \ >> './src/cmd/builtin/tr.c' \ >> './src/cmd/builtin/od.c' \ >> './src/cmd/kshlib/cmdtst/grep.c' \ >> './src/cmd/kshlib/cmdtst/xargs.c' \ >> 'src/lib/libcmd/.' >> [snip] >> -- snip -- >> ) and didn't hit any new issues except the reported generic job >> control issues with shell builtins. > > Roland, can you send us a complete script so we can use this for > deployment for Linux/x86, Linux/S390X and Solaris/SPARC64? Thank you.
AIX and HP/UX, too. Irek _______________________________________________ ast-developers mailing list [email protected] https://mailman.research.att.com/mailman/listinfo/ast-developers
