sorry about the invalid example using ',' separator
the options must be space separated

the problem with validating PACKAGE_OPTIONS values is that there
isn't really a central authority for what they can be

for bin/package PACKAGE_OPTIONS is just an opaque envelope

the values are referenced mainly the nmake base rules and iffe
but they can also be referenced in makefiles
its that last two usages where a validation might hinder evolution

On Thu, 14 Jun 2012 04:25:47 +0200 Roland Mainz wrote:
> On Mon, Jun 4, 2012 at 9:16 PM, Glenn Fowler <[email protected]> wrote:
> >
> > build with
> >        export PACKAGE_OPTIONS=optimize-space
> >
> > if you are doing a map-libc build then use
> >        export PACKAGE_OPTIONS=map-libc,optimize-space

> Erm... AFAIK "," isn't a valid seperator in this case (at least it
> doesn't work in ast-open.2012-06-12) ... AFAIK this should be $ export
> PACKAGE_OPTIONS="map-libc optimize-space" ... # (I just wasted another
> 30mins on digging that issue out... ;-( ).

> BTW: Is it possible to add a "safeguard" to stop the build at the
> beginning if unrecognised options are passed to PACKAGE_OPTIONS,
> please ? It would help a lot to find typos or language differences
> (e.g. "optimise" vs. "optimize") which introduce subtle issues in
> wrapper scripts around ./bin/package ...

> ----

> Bye,
> Roland

> -- 
>   __ .  . __
>  (o.\ \/ /.o) [email protected]
>   \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
>   /O /==\ O\  TEL +49 641 3992797
>  (;O/ \/ \O;)

_______________________________________________
ast-developers mailing list
[email protected]
https://mailman.research.att.com/mailman/listinfo/ast-developers

Reply via email to