On Sun, Jun 17, 2012 at 12:23 AM, Roland Mainz <[email protected]> wrote:
> Hi!
>
> ----
>
> Attached (as "astopen20120612_o_cloexec_patch20120616_001.diff") is a
> patch which replaces some of the |open()|+|fcntl(...,F_CLOEXEC)|
> sequences in ast-open.2012-06-12 with  |open(...,O_CLOEXEC)|  if the
> |O_CLOEXEC| CPP symbol is available on that platform (I've tested with
> Solaris 11 and SuSE 12.1).
>
> IMO the patch is simple&&safe enough for ksh93u+, too.

BTW: I forgot two notes:
1. I didn't touch ./src/cmd/builtin/pty.c ... but IMO it may be worth
(from the viewpoint of code space reduction) to apply the same
procedure to that code, too
2. Main goal of the patch is to reduce the number of syscalls (which
are expensive) and a (minor) code space reduction

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) [email protected]
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 3992797
 (;O/ \/ \O;)

_______________________________________________
ast-developers mailing list
[email protected]
https://mailman.research.att.com/mailman/listinfo/ast-developers

Reply via email to