----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2987/#review10232 -----------------------------------------------------------
Ship it! branches/12/include/asterisk/stasis.h <https://reviewboard.asterisk.org/r/2987/#comment19576> sanitize branches/12/include/asterisk/stasis.h <https://reviewboard.asterisk.org/r/2987/#comment19577> sanitize - Joshua Colp On Nov. 11, 2013, 3:12 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/2987/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 3:12 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-22744 > https://issues.asterisk.org/jira/browse/ASTERISK-22744 > > > Repository: Asterisk > > > Description > ------- > > This change prevents channels used as implementation details from leaking out > to ARI. It does this by preventing creation of JSON blobs of channel > snapshots created from those channels and sanitizing JSON blobs of bridge > snapshots as they are created. This introduces a framework for excluding > information from output targeted at Stasis applications on a > consumer-by-consumer basis using channel sanitization callbacks which could > be extended to bridges or endpoints if necessary. > > This results in NULL inputs to ast_json_pack calls which generate unhelpful > error messages, so that has been dealt with as well. > > This also corrects a bug I noticed while investigating the issue where > BridgeCreated events would not be created. > > > Diffs > ----- > > branches/12/res/stasis/app.c 402347 > branches/12/res/res_stasis.c 402347 > branches/12/res/ari/resource_endpoints.c 402347 > branches/12/res/ari/resource_channels.c 402347 > branches/12/res/ari/resource_bridges.c 402347 > branches/12/main/stasis_message.c 402347 > branches/12/main/stasis_endpoints.c 402347 > branches/12/main/stasis_channels.c 402347 > branches/12/main/stasis_bridges.c 402347 > branches/12/main/rtp_engine.c 402347 > branches/12/main/json.c 402347 > branches/12/include/asterisk/stasis_endpoints.h 402347 > branches/12/include/asterisk/stasis_channels.h 402347 > branches/12/include/asterisk/stasis_bridges.h 402347 > branches/12/include/asterisk/stasis_app.h 402347 > branches/12/include/asterisk/stasis.h 402347 > > Diff: https://reviewboard.asterisk.org/r/2987/diff/ > > > Testing > ------- > > Manual testing with bridges and channels. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
