----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3048/#review10330 -----------------------------------------------------------
/asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/pjsip.conf <https://reviewboard.asterisk.org/r/3048/#comment19733> This will probably have issues on the build agents. Because the sip.conf.sample binds chan_sip to 0.0.0.0:5060, any pjsip.conf that also attempts to bind at a local address on 5060 can run into issues. chan_sip can intercept the packets and muck with the test. We could bind to 5061 instead - or we could go with a more "behind the scenes" solution and have the test object somehow manipulate it such that chan_sip isn't loaded or gets a different, non-standard config. This is really a problem with most of the PJSIP tests, but we might as well think about the best way to solve it here as well. /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml <https://reviewboard.asterisk.org/r/3048/#comment19732> Tag here should probably be PJSIP /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/run-test <https://reviewboard.asterisk.org/r/3048/#comment19734> Red /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/run-test <https://reviewboard.asterisk.org/r/3048/#comment19735> Granted this is probably copy/pasta, but throughout this test I'd avoid using print. Use the logger so that the error messages get handled by the logger appropriately. /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/run-test <https://reviewboard.asterisk.org/r/3048/#comment19736> start_asterisk/stop_asterisk are now NoOps. You can remove them. /asterisk/trunk/tests/fax/tests.yaml <https://reviewboard.asterisk.org/r/3048/#comment19730> While you're here (and when you've committed this), go ahead and throw the existing chan_sip based tests under a 'sip' directory. - Matt Jordan On Dec. 5, 2013, 5:24 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3048/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 5:24 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > This adds tests for T.38 faxing using chan_pjsip. Sending and receiving are > covered, as is gatewaying. > > > Diffs > ----- > > /asterisk/trunk/tests/fax/tests.yaml 4366 > /asterisk/trunk/tests/fax/pjsip/tests.yaml PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/t38/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/t38/send.tiff UNKNOWN > /asterisk/trunk/tests/fax/pjsip/t38/run-test PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/t38/configs/ast2/sip.conf PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/t38/configs/ast2/pjsip.conf PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/t38/configs/ast2/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/t38/configs/ast1/sip.conf PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/t38/configs/ast1/pjsip.conf PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/t38/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/test-config.yaml > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/send.tiff UNKNOWN > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/run-test PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast2/sip.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast2/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast1/sip.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/test-config.yaml > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/send.tiff UNKNOWN > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/run-test PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast2/sip.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast2/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast2/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast1/sip.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/sipp/inject_bridge.csv > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/sipp/endpoint_B.xml > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/sipp/endpoint_A.xml > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/sip.conf > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3048/diff/ > > > Testing > ------- > > Ran tests with framehook patch, all passed. Looked at logs and confirmed > happy. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
